console log pretty #3180
Merged
console log pretty #3180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kasjer
force-pushed
the
kasjer/console-log-pretty
branch
from
fd60bc2
to
512ae3f
Compare
|
why not just |
kasjer
force-pushed
the
kasjer/console-log-pretty
branch
2 times, most recently
from
f0ce919
to
231cf0e
Compare
|
@andrzej-kaczmarek updated as requested |
rymanluk
approved these changes
Apr 12, 2024
Current code had switch in function log_module_get_name() that returned module name based on some syscfg value first then it search modules registered by log_module_register(). Some of the syscfg values used in this code were referring to be values that are not any syscfg.yml file. Now code calls first auto-genereated function logcfg_log_module_name() to get those names. Signed-off-by: Jerzy Kasenberg <jerzy.kasenberg@codecoup.pl>
DFLT_LOG has now log name specified in syscfg to keep "DEFAULT" as default module log name. Without this change name would be "DLFT" Signed-off-by: Jerzy Kasenberg <jerzy.kasenberg@codecoup.pl>
This sets module name for logging to nicer values Signed-off-by: Jerzy Kasenberg <jerzy.kasenberg@codecoup.pl>
console print was using series of hexadecimal formatting without specifying filed size it could result in misleading printout where leading zeros for each byte are missing. Now format makes sure that all digits are present. Signed-off-by: Jerzy Kasenberg <jerzy.kasenberg@codecoup.pl>
This introduces alternative output of mod log header. Log mod module was printed: mod=0 now it is displayed this way: [DEFAULT] Log level used to be: level=2 Now it is: [WRN] of nothing if color are requested Time stamp is not displayed by default if CONSOLE_TICKS is 1 Severity level can be printed in color. Additional syscfg values that can be used: LOG_CONSOLE_PRETTY enable alternative display LOG_CONSOLE_PRETTY_WITH_COLORS enables colors for severity level LOG_CONSOLE_PRETTY_WITH_TIMESTAMP enables/disables time stamp printing Signed-off-by: Jerzy Kasenberg <jerzy.kasenberg@codecoup.pl>
kasjer
force-pushed
the
kasjer/console-log-pretty
branch
from
231cf0e
to
12383a1
Compare
sjanc
approved these changes
Apr 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds alternative way of printing mod log logs.
This change requires apache/mynewt-newt#551
New syscfg values that can be use to configure console printing
Old way of showing mod log logs:
New way: