Add a way to set linker flags --whole-archive and --no-whole-archive per pkg #520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…be set per package
|
sorry for late reply, looks OK to me! @m-gorecki could you look at this? |
|
LGTM |
|
@jocelynmass hi Jocelyn, your change seems ok and useful there are some conflicts due to late review. Would you care to rebase is it removing conflicts? If you don't have time I can do it. In this case I will force push resolved conflicts and it will be merged soon. |
|
@kasjer thanks just fixed the merge. |
sjanc
approved these changes
Apr 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depending on the project, it might be useful to have the ability to link a package surrounded by "--whole-archive" and "--no-whole-archive" flags.
I tweaked the code to allow pkg.whole_archive option to be set to true or false. I'm completely new to Goland so the code I made is most likely garbage. I just submit this PR with the hope that someone with more skills would take over this and fully make it to the next newt release.