Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

newt: Generate link tables header #542

Merged
merged 1 commit into from
Feb 22, 2024
Merged

Conversation

m-gorecki
Copy link
Contributor

@m-gorecki m-gorecki commented Feb 19, 2024

Adding pkg.link_tables field with link tables names will result
in generation of link_tables.ld.h file which will be used
in auto-generated linker script.

Adding pkg.link_tables field with link tables names will result
in generation of link_tables.ld.h file which will be used
in auto-generated linker script.
@m-gorecki m-gorecki changed the title wip: generate linker sections newt: Generate link tables header Feb 21, 2024
@m-gorecki m-gorecki marked this pull request as ready for review February 21, 2024 10:57
Copy link
Contributor

@kasjer kasjer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected.

@sjanc sjanc merged commit 6cffebf into apache:master Feb 22, 2024
59 checks passed
@andrzej-kaczmarek
Copy link
Contributor

how does this work if build contains more than 1 package using this feature?

@m-gorecki
Copy link
Contributor Author

@andrzej-kaczmarek Entries from each pkg used in the build will be collected and placed in the generated header.

@andrzej-kaczmarek
Copy link
Contributor

so I don't really understand what's the purpose of that if everything is put in single and thus can only be included in single section of linker script...

@kasjer
Copy link
Contributor

kasjer commented Feb 23, 2024

@andrzej-kaczmarek It's put in one section (for cortex it's in .text just before .rodata) but it adds __<section>__start__ and __<section>__end__ that can be referred in code making link time tables

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants