newt: Fix shallow upgrade with specific commit version #543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
newt/repo/version.go
Outdated
| @@ -126,6 +126,15 @@ func (r *Repo) VersionIsValid(ver newtutil.RepoVersion) bool { | |||
| } | |||
|
|
|||
| cs, _ := r.downloader.CommitsFor(r.Path(), ver.Commit) | |||
|
|
|||
| // For shallow copy commit might not be fetched yet | |||
There was a problem hiding this comment.
this could be actually done regardless of whether repo is shallow or now
the same problem exists if user specifies a commit that is not preset on any remote branch, e.g. a sha for PR head
Upgrading project using shallow option was causing an error if repository version was specified as specific commit. Because this specific commit could not yet be fetched it could not be found during version validation. Now if specific commit could not be found, instead of returning an error immediately, we first try to fetch it.
sjanc
approved these changes
Mar 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrading project using shallow option was causing an error if repository version was specified as specific commit. Because this specific commit could not yet be fetched it could not be found during version validation.
Now if shallow upgrade is being performed, instead of returning an error immediately after commit was not found, we first try to fetch the specified commit.