Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow overriding MYNEWT_DOWNLOADER from command line #556

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

m-gorecki
Copy link
Contributor

This adds new flag to load and run commands.
The flag (--loader or short -L) allows to override the MYNEWT_DOWNLOADER value from syscfg. Usage example:

--loader stm32_programmer_cli

This adds new flag to load and run commands.
The flag (--loader or short -L) allows to override the
MYNEWT_DOWNLOADER value from syscfg. Usage example:
--loader stm32_programmer_cli
@andrzej-kaczmarek
Copy link
Contributor

-S can be already used to override syscfg from command line

@m-gorecki
Copy link
Contributor Author

In case of loading, there is no use overriding other configs than MYNEWT_DOWNLOADER. I assumed it would be better to simply allow user to override only this specific syscfg value. Under the hood it uses the same code to override the value as -S flag, it's just wrapped to not cause confusion

@andrzej-kaczmarek
Copy link
Contributor

my main concern is that this simply overrides syscfg defined in some package - that doesn't sound like a maintainable solution.

would be better if we "simply" add loader packages as a generic solution, i.e. add pkg.type: loader and move all scripts there. bsp would then specify default and/or supported loader(s) which could be overridden from command line.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants