newt: Extend link tables filter #558
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So far for link time generated tables only exact section name
was added to filter like in this example:
pkg.link_tables:
- foo
would generate link_tables.ld.h with following content
__foo_start__ = .;
KEEP(*(.foo))
__foo_end__ = .;
Now additional filter will be added
__foo_start__ = .;
KEEP(*(.foo))
KEEP(*(SORT(.foo.*)))
__foo_end__ = .;
This is general rule for many sections like .text or .data
This is specifically required for xc32 compiler that
adds variable name to section by itself even though
__attribute__((section, "foo")) is used and arm gcc
treats name in attribute verbatim and not as prefix.
sjanc
approved these changes
Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So far for link time generated tables only exact section name was added to filter like in this example:
would generate link_tables.ld.h with following content
Now additional filter will be added
This is general rule for many sections like .text or .data
This is specifically required for xc32 compiler that adds variable name to section by itself even though
__attribute__((section, "foo"))is used and arm gcc treats name in attribute verbatim and not as prefix.