Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix whole archive compiler flag handling #559

Closed

Conversation

vrahane
Copy link
Contributor

@vrahane vrahane commented May 17, 2024

No description provided.

@vrahane vrahane requested a review from wes3 May 17, 2024 21:16
Copy link
Contributor

@sjanc sjanc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please explain what exactly is fixed here in commit message

@vrahane
Copy link
Contributor Author

vrahane commented May 24, 2024

This does not fix anything. We were seeing some image hash changes on subsequent builds but that was because of something else. Initial thought was this caused it but it didn’t.

@vrahane vrahane closed this May 24, 2024
@vrahane vrahane deleted the vipul/fix_whole_archive_compiler_fag_handling branch August 19, 2024 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants