Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Report ambiguous syscfg configuration #566

Merged
merged 2 commits into from
Sep 6, 2024
Merged

Report ambiguous syscfg configuration #566

merged 2 commits into from
Sep 6, 2024

Conversation

m-gorecki
Copy link
Contributor

This addresses: #565

@sjanc
Copy link
Contributor

sjanc commented Aug 22, 2024

would be good to also add unit test that will validate this before closing issue

sjanc
sjanc reviewed Aug 22, 2024
View reviewed changes
Copy link
Contributor

@sjanc sjanc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this also needs to validate if value differs as it is fine to set it to same value from multiple locations

@sjanc sjanc self-requested a review August 22, 2024 12:42
@m-gorecki m-gorecki merged commit 15c4ac6 into apache:master Sep 6, 2024
64 checks passed
@sjanc
Copy link
Contributor

sjanc commented Sep 9, 2024

seems to be crashing on specific target
https://github.com/apache/mynewt-nimble/actions/runs/10739293391/job/29840180220?pr=1851

(can be reproduced with .github/nordic_pca10028_blehci target from nimble repo)

@m-gorecki
Copy link
Contributor Author

This should fix the issue: #570

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sjanc sjanc sjanc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@m-gorecki @sjanc