Skip to content

Commit

Permalink
ext/libsamplerate: always build with DNDEBUG flag
Browse files Browse the repository at this point in the history
Debug build pulls assert.h and nrfx, in which PACKAGE define isi pulled from
libsamplerate/serc/config.h. This is not correct behavior and these
defines are not correlated. Library should be always build without
asserts, circumventing the issue.

Cleaned up duplicated cflags in pkg.yml.
  • Loading branch information
KKopyscinski committed Mar 11, 2024
1 parent 253f590 commit 0ccd122
Showing 1 changed file with 1 addition and 5 deletions.
6 changes: 1 addition & 5 deletions ext/libsamplerate/pkg.yml
Original file line number Diff line number Diff line change
Expand Up @@ -26,11 +26,7 @@ pkg.keywords:

pkg.type: sdk

pkg.cflags: -DHAVE_STDBOOL_H -fsingle-precision-constant -DHAVE_CONFIG_H
pkg.cflags.ENABLE_SINC_BEST_CONVERTER: -DENABLE_SINC_BEST_CONVERTER
pkg.cflags.ENABLE_SINC_MEDIUM_CONVERTER: -DENABLE_SINC_MEDIUM_CONVERTER
pkg.cflags.ENABLE_SINC_FAST_CONVERTER: -DENABLE_SINC_FAST_CONVERTER
pkg.cflags.LIBSAMPLER_NDEBUG: -DNDEBUG
pkg.cflags: -DHAVE_STDBOOL_H -fsingle-precision-constant -DHAVE_CONFIG_H -DNDEBUG
pkg.lflags: -lm

pkg.ign_dirs:
Expand Down

0 comments on commit 0ccd122

Please sign in to comment.