apps/bleservo: Initial commit #1320
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m-gorecki
force-pushed
the
ble-servo
branch
2 times, most recently
from
da8f5b9
to
a1d2330
Compare
m-gorecki
force-pushed
the
ble-servo
branch
from
a1d2330
to
402fda6
Compare
Style check summaryOur coding style is here!apps/bleservo/src/gatt_svr.c@@ -82,24 +82,24 @@
.type = BLE_GATT_SVC_TYPE_PRIMARY,
.uuid = &gatt_svr_svc_servo_uuid.u,
.characteristics = (struct ble_gatt_chr_def[]) { {
- /* Characteristic: servo angle*/
- .uuid = &gatt_svr_chr_servo_angle_uuid.u,
- .val_handle = &gatt_angle_val_handle,
- .access_cb = gatt_svr_chr_access_servo_angle,
- .flags = BLE_GATT_CHR_F_READ |
- BLE_GATT_CHR_F_WRITE |
- BLE_GATT_CHR_F_NOTIFY
- }, {
- /* Characteristic: servo PWM pulse duration*/
- .uuid = &gatt_svr_chr_servo_pulse_duration_uuid.u,
- .val_handle = &gatt_pulse_duration_val_handle,
- .access_cb = gatt_svr_chr_access_servo_pulse_duration,
- .flags = BLE_GATT_CHR_F_READ |
- BLE_GATT_CHR_F_WRITE |
- BLE_GATT_CHR_F_NOTIFY
- }, {
- 0, /* No more characteristics in this service */
- }, }
+ /* Characteristic: servo angle*/
+ .uuid = &gatt_svr_chr_servo_angle_uuid.u,
+ .val_handle = &gatt_angle_val_handle,
+ .access_cb = gatt_svr_chr_access_servo_angle,
+ .flags = BLE_GATT_CHR_F_READ |
+ BLE_GATT_CHR_F_WRITE |
+ BLE_GATT_CHR_F_NOTIFY
+ }, {
+ /* Characteristic: servo PWM pulse duration*/
+ .uuid = &gatt_svr_chr_servo_pulse_duration_uuid.u,
+ .val_handle = &gatt_pulse_duration_val_handle,
+ .access_cb = gatt_svr_chr_access_servo_pulse_duration,
+ .flags = BLE_GATT_CHR_F_READ |
+ BLE_GATT_CHR_F_WRITE |
+ BLE_GATT_CHR_F_NOTIFY
+ }, {
+ 0, /* No more characteristics in this service */
+ }, }
},
{ |
m-gorecki
changed the title
m-gorecki
force-pushed
the
ble-servo
branch
3 times, most recently
from
9d5ad74
to
2308605
Compare
m-gorecki
force-pushed
the
ble-servo
branch
2 times, most recently
from
c4a67d7
to
484a0d9
Compare
sjanc
reviewed
Oct 27, 2023
|
|
||
| syscfg.yml contains setting definitions and overrides. | ||
|
|
||
| On default servo PWM channel is connected to pin 31 of nRF52840-DK board, |
There was a problem hiding this comment.
make this syscfg instead of requireing to modify source
sjanc
reviewed
Oct 27, 2023
apps/bleservo/syscfg.yml
Outdated
| BLE_ROLE_PERIPHERAL: 1 | ||
|
|
||
| # Disable unused eddystone feature. | ||
| BLE_EDDYSTONE: 0 |
There was a problem hiding this comment.
this is a leftover, eddystone doesn't have syscfg config
sjanc
reviewed
Oct 27, 2023
apps/bleservo/syscfg.yml
Outdated
| BLE_EDDYSTONE: 0 | ||
|
|
||
| # Set public device address. | ||
| BLE_LL_PUBLIC_DEV_ADDR: 0x1122aabb33cc |
There was a problem hiding this comment.
no god, please, no! noooo! ;-)
nRF52840-DK BLE peripheral sample with PWM servo control ability.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nRF52840-DK BLE peripheral sample with PWM servo control ability.