Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nimble/transport: Add UART transport for external controller #1399

Merged
merged 1 commit into from
Jun 23, 2023
Merged

nimble/transport: Add UART transport for external controller #1399

merged 1 commit into from
Jun 23, 2023

Conversation

andrzej-kaczmarek
Copy link
Contributor

This is the same as standard "uart" transport except it's for LL side which means it can be used for NimBLE host to talk to external controller. Enable it by "BLE_TRANSPORT_LL: uart_ll".

@apache-mynewt-bot
Copy link

Style check summary

No suggestions at this time!

jocelynmass
jocelynmass reviewed Oct 21, 2022
View reviewed changes
nimble/transport/syscfg.yml Outdated
@@ -46,6 +46,7 @@ syscfg.defs:
- nrf5340
- socket
- apollo3
- uart_hs
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this value be uart_ll instead?

@jocelynmass
Copy link

Tested and working! Thanks

@trail-coffee trail-coffee mentioned this pull request Jan 9, 2023
Open
@suadsuljic7 suadsuljic7 mentioned this pull request Jan 27, 2023
Closed
@AxelLin
Copy link
Contributor

AxelLin commented Feb 24, 2023

Hi,
Will this PR be merged in next release?

@andrzej-kaczmarek
Copy link
Contributor Author

Yes, although I am thinking of merging this into existing UART H4 transport so we don't duplicate code unnecessarily. But this feature will be available in next release.

@AxelLin
Copy link
Contributor

AxelLin commented Feb 25, 2023

Hi @andrzej-kaczmarek
Thanks for the prompt reply.
This feature was working in NimBLE-1.4.0, I'm surprised that it was missed in NimBLE-1.5.0. (So please consider it as a bug fix)
What's the target release timeline for next release?

@AxelLin
Copy link
Contributor

AxelLin commented Apr 13, 2023

Yes, although I am thinking of merging this into existing UART H4 transport so we don't duplicate code unnecessarily. But this feature will be available in next release.

Any update for merging this? @andrzej-kaczmarek

@andrzej-kaczmarek
nimble/transport: Add UART transport for external controller
620907b 
This is the same as standard "uart" transport except it's for LL side
which means it can be used for NimBLE host to talk to external
controller. Enable it by "BLE_TRANSPORT_LL: uart_ll".
@andrzej-kaczmarek andrzej-kaczmarek merged commit 80ef459 into apache:master Jun 23, 2023
8 checks passed
@andrzej-kaczmarek andrzej-kaczmarek deleted the transport-uart_ll branch June 23, 2023 15:09
@bojanpotocnik bojanpotocnik mentioned this pull request May 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jocelynmass jocelynmass jocelynmass left review comments

@sjanc sjanc sjanc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@andrzej-kaczmarek @apache-mynewt-bot @jocelynmass @AxelLin @sjanc