nimble/host: Set length correctly in perdioic_set_adv_data #1539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rahult-github
force-pushed
the
bugfix/handle_NULL_data_periodic_adv
branch
from
75f77d2
to
898af6f
Compare
sjanc
requested changes
Jul 3, 2023
rahult-github
force-pushed
the
bugfix/handle_NULL_data_periodic_adv
branch
from
898af6f
to
c04b6ae
Compare
Thanks for pointing this out. I have updated the patch to copy data only if len is valid . ( in the cases where length can be zero ) |
rahult-github
force-pushed
the
bugfix/handle_NULL_data_periodic_adv
branch
from
c04b6ae
to
4bc16db
Compare
|
Hi @sjanc , please let me know if there are any more comments. |
rahult-github
force-pushed
the
bugfix/handle_NULL_data_periodic_adv
branch
from
4bc16db
to
8f97e63
Compare
This change sets length field only if data is non NULL, else sets length to zero.
rahult-github
force-pushed
the
bugfix/handle_NULL_data_periodic_adv
branch
from
8f97e63
to
e298bd8
Compare
sjanc
approved these changes
Oct 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change sets length field only if data is non NULL, else sets length to zero.
Core 5.4, Vol 4, Part E, section 7.8.62 states
"If Operation is not 0x03 or 0x04 and Advertising_Data_Length is zero, then the Controller shall return the error code Invalid HCI Command Parameters (0x12).."
Current code sets length to size of data. However, to validate above, need to send 0 length . So calculate length only if data is present.