Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Btp refactor #1543

Merged
merged 12 commits into from
Jul 26, 2023
Merged

Btp refactor #1543

merged 12 commits into from
Jul 26, 2023

Conversation

KKopyscinski
Copy link
Contributor

No description provided.

@KKopyscinski KKopyscinski force-pushed the btp_refactor branch 7 times, most recently from 17cc5c9 to b60204b Compare July 12, 2023 10:36
@KKopyscinski KKopyscinski requested a review from sjanc July 13, 2023 08:11
@KKopyscinski KKopyscinski marked this pull request as ready for review July 13, 2023 08:17
@sjanc
Copy link
Contributor

sjanc commented Jul 13, 2023

#AutoPTS run mynewt GAP GATT SM L2CAP

@codecoup-tester
Copy link

Scheduled PR ##1543 (comment) after 11:15:52.

@codecoup-tester
Copy link

Scheduled PR ##1543 (comment) after 12:11:41.

@sjanc
Copy link
Contributor

sjanc commented Jul 18, 2023

#AutoPTS run mynewt SM/CEN

@codecoup-tester
Copy link

Scheduled PR ##1543 (comment) after 09:41:03.

@codecoup-tester
Copy link

AutoPTS Bot results:

Failed testsSM SM/CEN/PROT/BV-01-C BTP ERROR
SM SM/CEN/JW/BV-05-C BTP ERROR
SM SM/CEN/JW/BI-04-C BTP ERROR
SM SM/CEN/JW/BI-01-C BTP ERROR
SM SM/CEN/PKE/BV-01-C BTP ERROR
SM SM/CEN/PKE/BV-04-C BTP ERROR
SM SM/CEN/PKE/BI-01-C BTP ERROR
SM SM/CEN/PKE/BI-02-C BTP ERROR
SM SM/CEN/OOB/BV-01-C BTP ERROR
SM SM/CEN/OOB/BV-03-C BTP ERROR
SM SM/CEN/OOB/BV-09-C BTP ERROR
SM SM/CEN/OOB/BI-01-C BTP ERROR
SM SM/CEN/EKS/BV-01-C BTP ERROR
SM SM/CEN/EKS/BI-01-C BTP ERROR
SM SM/CEN/KDU/BV-05-C BTP ERROR
SM SM/CEN/KDU/BV-06-C BTP ERROR - ERRATA TSE19221
SM SM/CEN/KDU/BV-10-C BTP ERROR
SM SM/CEN/KDU/BI-01-C BTP ERROR
SM SM/CEN/SIP/BV-02-C BTP ERROR
SM SM/CEN/SCJW/BV-01-C BTP ERROR
SM SM/CEN/SCJW/BV-04-C BTP ERROR
SM SM/CEN/SCJW/BI-01-C BTP ERROR
SM SM/CEN/SCPK/BV-01-C BTP ERROR
SM SM/CEN/SCPK/BV-04-C BTP ERROR
SM SM/CEN/SCPK/BI-01-C BTP ERROR
SM SM/CEN/SCPK/BI-02-C BTP ERROR
SM SM/CEN/SCOB/BV-01-C BTP ERROR
SM SM/CEN/SCOB/BV-04-C BTP ERROR
SM SM/CEN/SCOB/BI-01-C BTP ERROR
SM SM/CEN/SCOB/BI-04-C BTP ERROR

@sjanc
Copy link
Contributor

sjanc commented Jul 18, 2023

#AutoPTS run mynewt SM/CEN

@codecoup-tester
Copy link

Scheduled PR ##1543 (comment) after 10:18:54.

@KKopyscinski
apps/bttester: split bttester.h and add btp_ prefixes
6d9284d 
Splits `bttester.h` into seperate files, one for each BTP
service. Adds BTP_ prefix for defines and btp_ prefix for
structs.
@codecoup-tester
Copy link

AutoPTS Bot results:

Failed testsSM SM/CEN/PROT/BV-01-C BTP TIMEOUT
SM SM/CEN/JW/BV-05-C BTP TIMEOUT
SM SM/CEN/JW/BI-04-C BTP TIMEOUT
SM SM/CEN/JW/BI-01-C BTP TIMEOUT
SM SM/CEN/PKE/BV-01-C BTP TIMEOUT
SM SM/CEN/PKE/BV-04-C BTP TIMEOUT
SM SM/CEN/PKE/BI-01-C BTP TIMEOUT
SM SM/CEN/PKE/BI-02-C BTP TIMEOUT
SM SM/CEN/OOB/BV-01-C BTP TIMEOUT
SM SM/CEN/OOB/BV-03-C BTP TIMEOUT
SM SM/CEN/OOB/BV-09-C BTP TIMEOUT
SM SM/CEN/OOB/BI-01-C BTP TIMEOUT
SM SM/CEN/EKS/BV-01-C BTP TIMEOUT
SM SM/CEN/EKS/BI-01-C BTP TIMEOUT
SM SM/CEN/KDU/BV-05-C BTP TIMEOUT
SM SM/CEN/KDU/BV-06-C BTP TIMEOUT - ERRATA TSE19221
SM SM/CEN/KDU/BV-10-C BTP TIMEOUT
SM SM/CEN/KDU/BI-01-C BTP TIMEOUT
SM SM/CEN/SIP/BV-02-C BTP TIMEOUT
SM SM/CEN/SCJW/BV-01-C BTP TIMEOUT
SM SM/CEN/SCJW/BV-04-C BTP TIMEOUT
SM SM/CEN/SCJW/BI-01-C BTP TIMEOUT
SM SM/CEN/SCPK/BV-01-C BTP TIMEOUT
SM SM/CEN/SCPK/BV-04-C BTP TIMEOUT
SM SM/CEN/SCPK/BI-01-C BTP TIMEOUT
SM SM/CEN/SCPK/BI-02-C BTP TIMEOUT
SM SM/CEN/SCOB/BV-01-C BTP TIMEOUT
SM SM/CEN/SCOB/BV-04-C BTP TIMEOUT
SM SM/CEN/SCOB/BI-01-C BTP TIMEOUT
SM SM/CEN/SCOB/BI-04-C BTP TIMEOUT

@sjanc
Copy link
Contributor

sjanc commented Jul 19, 2023

#AutoPTS run mynewt SM/CEN

@codecoup-tester
Copy link

Scheduled PR ##1543 (comment) after 11:08:52.

@codecoup-tester
Copy link

AutoPTS Bot results:
No failed test found.

Successful testsSM SM/CEN/PROT/BV-01-C PASS
SM SM/CEN/JW/BV-05-C PASS
SM SM/CEN/JW/BI-04-C PASS
SM SM/CEN/JW/BI-01-C PASS
SM SM/CEN/PKE/BV-01-C PASS
SM SM/CEN/PKE/BV-04-C PASS
SM SM/CEN/PKE/BI-01-C PASS
SM SM/CEN/PKE/BI-02-C PASS
SM SM/CEN/OOB/BV-01-C PASS
SM SM/CEN/OOB/BV-03-C PASS
SM SM/CEN/OOB/BV-09-C PASS
SM SM/CEN/OOB/BI-01-C PASS
SM SM/CEN/EKS/BV-01-C PASS
SM SM/CEN/EKS/BI-01-C PASS
SM SM/CEN/KDU/BV-05-C PASS
SM SM/CEN/KDU/BV-06-C PASS - ERRATA TSE19221
SM SM/CEN/KDU/BV-10-C PASS
SM SM/CEN/KDU/BI-01-C PASS
SM SM/CEN/SIP/BV-02-C PASS
SM SM/CEN/SCJW/BV-01-C PASS
SM SM/CEN/SCJW/BV-04-C PASS
SM SM/CEN/SCJW/BI-01-C PASS
SM SM/CEN/SCPK/BV-01-C PASS
SM SM/CEN/SCPK/BV-04-C PASS
SM SM/CEN/SCPK/BI-01-C PASS
SM SM/CEN/SCPK/BI-02-C PASS
SM SM/CEN/SCOB/BV-01-C PASS
SM SM/CEN/SCOB/BV-04-C PASS
SM SM/CEN/SCOB/BI-01-C PASS
SM SM/CEN/SCOB/BI-04-C PASS

@KKopyscinski
apps/bttester: refactor BTP handling
f9acbd5 
This commit refactors BTP handling to new model, where API is provided for
registration of handlers for BTP commands as callbacks. New API provides also
size check and common buffer for response.

Removes Controlle Index validation from BTP handlers, as these are always 0.

Corrected some formatting for variable declarations.

This refactors only core and GAP service into new API, rest of services will
not work but are compiled. They will be refactored in following commits.
@sjanc
Copy link
Contributor

sjanc commented Jul 19, 2023

#AutoPTS run mynewt GAP SM

@codecoup-tester
Copy link

Scheduled PR ##1543 (comment) after 11:54:23.

@codecoup-tester
Copy link

AutoPTS Bot results:

Failed testsGAP GAP/BROB/BCST/BV-01-C BTP ERROR
GAP GAP/BROB/BCST/BV-02-C BTP ERROR
GAP GAP/BROB/OBSV/BV-01-C BTP ERROR
GAP GAP/BROB/OBSV/BV-02-C BTP ERROR
GAP GAP/BROB/OBSV/BV-05-C BTP ERROR
GAP GAP/BROB/OBSV/BV-06-C BTP ERROR
GAP GAP/DISC/NONM/BV-01-C BTP ERROR
GAP GAP/DISC/NONM/BV-02-C BTP ERROR
GAP GAP/DISC/LIMM/BV-03-C BTP ERROR
GAP GAP/DISC/LIMM/BV-04-C BTP ERROR
GAP GAP/DISC/GENM/BV-04-C BTP ERROR
GAP GAP/DISC/LIMP/BV-01-C BTP ERROR
GAP GAP/DISC/LIMP/BV-02-C BTP ERROR
GAP GAP/DISC/LIMP/BV-03-C BTP ERROR
GAP GAP/DISC/LIMP/BV-04-C BTP ERROR
GAP GAP/DISC/LIMP/BV-05-C BTP ERROR
GAP GAP/DISC/GENP/BV-01-C BTP ERROR
GAP GAP/DISC/GENP/BV-02-C BTP ERROR
GAP GAP/DISC/GENP/BV-03-C BTP ERROR
GAP GAP/DISC/GENP/BV-04-C BTP ERROR
GAP GAP/DISC/GENP/BV-05-C BTP ERROR
GAP GAP/DISC/RPA/BV-01-C BTP ERROR
GAP GAP/IDLE/NAMP/BV-01-C BTP ERROR
GAP GAP/IDLE/NAMP/BV-02-C BTP ERROR
GAP GAP/CONN/NCON/BV-01-C BTP ERROR
GAP GAP/CONN/NCON/BV-02-C BTP ERROR
GAP GAP/CONN/NCON/BV-03-C BTP ERROR
GAP GAP/CONN/DCON/BV-01-C BTP ERROR
GAP GAP/CONN/UCON/BV-01-C BTP ERROR
GAP GAP/CONN/UCON/BV-02-C BTP ERROR
GAP GAP/CONN/UCON/BV-03-C BTP ERROR
GAP GAP/CONN/ACEP/BV-01-C BTP ERROR
GAP GAP/CONN/GCEP/BV-01-C BTP ERROR
GAP GAP/CONN/GCEP/BV-02-C BTP ERROR
GAP GAP/CONN/SCEP/BV-01-C BTP ERROR
GAP GAP/CONN/DCEP/BV-01-C BTP ERROR
GAP GAP/CONN/DCEP/BV-03-C BTP ERROR
GAP GAP/CONN/CPUP/BV-04-C BTP ERROR
GAP GAP/CONN/CPUP/BV-05-C BTP ERROR
GAP GAP/CONN/CPUP/BV-08-C BTP ERROR
GAP GAP/CONN/CPUP/BV-10-C BTP ERROR
GAP GAP/CONN/TERM/BV-01-C BTP ERROR
GAP GAP/CONN/PRDA/BV-01-C BTP ERROR
GAP GAP/CONN/PRDA/BV-02-C BTP ERROR
GAP GAP/BOND/NBON/BV-01-C BTP ERROR
GAP GAP/BOND/NBON/BV-02-C BTP ERROR
GAP GAP/BOND/NBON/BV-03-C BTP ERROR
GAP GAP/BOND/BON/BV-01-C BTP ERROR
GAP GAP/BOND/BON/BV-02-C BTP ERROR
GAP GAP/BOND/BON/BV-03-C BTP ERROR
GAP GAP/SEC/AUT/BV-11-C BTP ERROR
GAP GAP/SEC/AUT/BV-12-C BTP ERROR
GAP GAP/SEC/AUT/BV-13-C BTP ERROR
GAP GAP/SEC/AUT/BV-14-C BTP ERROR
GAP GAP/SEC/AUT/BV-17-C BTP ERROR
GAP GAP/SEC/AUT/BV-18-C BTP ERROR
GAP GAP/SEC/AUT/BV-19-C BTP ERROR
GAP GAP/SEC/AUT/BV-20-C BTP ERROR
GAP GAP/SEC/AUT/BV-21-C BTP ERROR
GAP GAP/SEC/AUT/BV-22-C BTP ERROR
GAP GAP/SEC/AUT/BV-23-C BTP ERROR
GAP GAP/SEC/AUT/BV-24-C BTP ERROR
GAP GAP/SEC/AUT/BV-25-C BTP ERROR
GAP GAP/SEC/AUT/BV-27-C BTP ERROR
GAP GAP/PRIV/CONN/BV-12-C BTP ERROR
GAP GAP/ADV/BV-01-C BTP ERROR
GAP GAP/ADV/BV-02-C BTP ERROR
GAP GAP/ADV/BV-03-C BTP ERROR
GAP GAP/ADV/BV-04-C BTP ERROR
GAP GAP/ADV/BV-05-C BTP ERROR
GAP GAP/ADV/BV-08-C BTP ERROR
GAP GAP/ADV/BV-10-C BTP ERROR
GAP GAP/ADV/BV-11-C BTP ERROR
GAP GAP/ADV/BV-14-C BTP ERROR
GAP GAP/ADV/BV-17-C BTP ERROR
GAP GAP/ADV/BV-18-C BTP ERROR
GAP GAP/PADV/PASM/BV-01-C BTP ERROR - ERRATA https://github:com/auto-pts/auto-pts/issues/740
GAP GAP/PADV/PAM/BV-01-C BTP ERROR - ERRATA https://github:com/auto-pts/auto-pts/issues/740
GAP GAP/PADV/PASE/BV-01-C BTP ERROR - ERRATA https://github:com/auto-pts/auto-pts/issues/740
GAP GAP/PADV/PASE/BV-02-C BTP ERROR - ERRATA https://github:com/auto-pts/auto-pts/issues/740
GAP GAP/PADV/PASE/BV-03-C BTP ERROR - ERRATA https://github:com/auto-pts/auto-pts/issues/740
GAP GAP/PADV/PASE/BV-04-C BTP ERROR - ERRATA https://github:com/auto-pts/auto-pts/issues/740
GAP GAP/PADV/PASE/BV-05-C BTP ERROR - ERRATA https://github:com/auto-pts/auto-pts/issues/740
GAP GAP/PADV/PASE/BV-06-C BTP ERROR - ERRATA https://github:com/auto-pts/auto-pts/issues/740
GAP GAP/PADV/PAST/BV-01-C BTP ERROR - ERRATA https://github:com/auto-pts/auto-pts/issues/740
GAP GAP/PADV/PAST/BV-02-C BTP ERROR - ERRATA https://github:com/auto-pts/auto-pts/issues/740
GAP GAP/GAT/BV-04-C BTP ERROR
GAP GAP/GAT/BV-05-C BTP ERROR
GAP GAP/GAT/BV-06-C BTP ERROR
Successful testsSM SM/CEN/PROT/BV-01-C PASS
SM SM/CEN/JW/BV-05-C PASS
SM SM/CEN/JW/BI-04-C PASS
SM SM/CEN/JW/BI-01-C PASS
SM SM/CEN/PKE/BV-01-C PASS
SM SM/CEN/PKE/BV-04-C PASS
SM SM/CEN/PKE/BI-01-C PASS
SM SM/CEN/PKE/BI-02-C PASS
SM SM/CEN/OOB/BV-01-C PASS
SM SM/CEN/OOB/BV-03-C PASS
SM SM/CEN/OOB/BV-09-C PASS

@codecoup-tester
Copy link

Scheduled PR ##1543 (comment) after 13:48:12.

@codecoup-tester
Copy link

AutoPTS Bot results:

Failed testsGAP GAP/BROB/BCST/BV-01-C BTP ERROR
GAP GAP/BROB/BCST/BV-02-C BTP ERROR
GAP GAP/BROB/OBSV/BV-01-C BTP ERROR
GAP GAP/BROB/OBSV/BV-02-C BTP ERROR
GAP GAP/BROB/OBSV/BV-05-C BTP ERROR
GAP GAP/BROB/OBSV/BV-06-C BTP ERROR
GAP GAP/DISC/NONM/BV-01-C BTP ERROR
GAP GAP/DISC/NONM/BV-02-C BTP ERROR
GAP GAP/DISC/LIMM/BV-03-C BTP ERROR
GAP GAP/DISC/LIMM/BV-04-C BTP ERROR
GAP GAP/DISC/GENM/BV-04-C BTP ERROR
GAP GAP/DISC/LIMP/BV-01-C BTP ERROR
GAP GAP/DISC/LIMP/BV-02-C BTP ERROR
GAP GAP/DISC/LIMP/BV-03-C BTP ERROR
GAP GAP/DISC/LIMP/BV-04-C BTP ERROR
GAP GAP/DISC/LIMP/BV-05-C BTP ERROR
GAP GAP/DISC/GENP/BV-01-C BTP ERROR
GAP GAP/DISC/GENP/BV-02-C BTP ERROR
GAP GAP/DISC/GENP/BV-03-C BTP ERROR
GAP GAP/DISC/GENP/BV-04-C BTP ERROR
GAP GAP/DISC/GENP/BV-05-C BTP ERROR
GAP GAP/DISC/RPA/BV-01-C BTP ERROR
GAP GAP/IDLE/NAMP/BV-01-C BTP ERROR
GAP GAP/IDLE/NAMP/BV-02-C BTP ERROR
GAP GAP/CONN/NCON/BV-01-C BTP ERROR
GAP GAP/CONN/NCON/BV-02-C BTP ERROR
GAP GAP/CONN/NCON/BV-03-C BTP ERROR
GAP GAP/CONN/DCON/BV-01-C BTP ERROR
GAP GAP/CONN/UCON/BV-01-C BTP ERROR
GAP GAP/CONN/UCON/BV-02-C BTP ERROR
GAP GAP/CONN/UCON/BV-03-C BTP ERROR
GAP GAP/CONN/ACEP/BV-01-C BTP ERROR
GAP GAP/CONN/GCEP/BV-01-C BTP ERROR
GAP GAP/CONN/GCEP/BV-02-C BTP ERROR
GAP GAP/CONN/SCEP/BV-01-C BTP ERROR
GAP GAP/CONN/DCEP/BV-01-C BTP ERROR
GAP GAP/CONN/DCEP/BV-03-C BTP ERROR
GAP GAP/CONN/CPUP/BV-04-C BTP ERROR
GAP GAP/CONN/CPUP/BV-05-C BTP ERROR
GAP GAP/CONN/CPUP/BV-08-C BTP ERROR
GAP GAP/CONN/CPUP/BV-10-C BTP ERROR
GAP GAP/CONN/TERM/BV-01-C BTP ERROR
GAP GAP/CONN/PRDA/BV-01-C BTP ERROR
GAP GAP/CONN/PRDA/BV-02-C BTP ERROR
GAP GAP/BOND/NBON/BV-01-C BTP ERROR
GAP GAP/BOND/NBON/BV-02-C BTP ERROR
GAP GAP/BOND/NBON/BV-03-C BTP ERROR
GAP GAP/BOND/BON/BV-01-C BTP ERROR
GAP GAP/BOND/BON/BV-02-C BTP ERROR
GAP GAP/BOND/BON/BV-03-C BTP ERROR
GAP GAP/SEC/AUT/BV-11-C BTP ERROR
GAP GAP/SEC/AUT/BV-12-C BTP ERROR
GAP GAP/SEC/AUT/BV-13-C BTP ERROR
GAP GAP/SEC/AUT/BV-14-C BTP ERROR
GAP GAP/SEC/AUT/BV-17-C BTP ERROR
GAP GAP/SEC/AUT/BV-18-C BTP ERROR
GAP GAP/SEC/AUT/BV-19-C BTP ERROR
GAP GAP/SEC/AUT/BV-20-C BTP ERROR
GAP GAP/SEC/AUT/BV-21-C BTP ERROR
GAP GAP/SEC/AUT/BV-22-C BTP ERROR
GAP GAP/SEC/AUT/BV-23-C BTP ERROR
GAP GAP/SEC/AUT/BV-24-C BTP ERROR
GAP GAP/SEC/AUT/BV-25-C BTP ERROR
GAP GAP/SEC/AUT/BV-27-C BTP ERROR
GAP GAP/PRIV/CONN/BV-12-C BTP ERROR
GAP GAP/ADV/BV-01-C BTP ERROR
GAP GAP/ADV/BV-02-C BTP ERROR
GAP GAP/ADV/BV-03-C BTP ERROR
GAP GAP/ADV/BV-04-C BTP ERROR
GAP GAP/ADV/BV-05-C BTP ERROR
GAP GAP/ADV/BV-08-C BTP ERROR
GAP GAP/ADV/BV-10-C BTP ERROR
GAP GAP/ADV/BV-11-C BTP ERROR
GAP GAP/ADV/BV-14-C BTP ERROR
GAP GAP/ADV/BV-17-C BTP ERROR
GAP GAP/ADV/BV-18-C BTP ERROR
GAP GAP/PADV/PASM/BV-01-C BTP ERROR - ERRATA https://github:com/auto-pts/auto-pts/issues/740
GAP GAP/PADV/PAM/BV-01-C BTP ERROR - ERRATA https://github:com/auto-pts/auto-pts/issues/740
GAP GAP/PADV/PASE/BV-01-C BTP ERROR - ERRATA https://github:com/auto-pts/auto-pts/issues/740
GAP GAP/PADV/PASE/BV-02-C BTP ERROR - ERRATA https://github:com/auto-pts/auto-pts/issues/740
GAP GAP/PADV/PASE/BV-03-C BTP ERROR - ERRATA https://github:com/auto-pts/auto-pts/issues/740
GAP GAP/PADV/PASE/BV-04-C BTP ERROR - ERRATA https://github:com/auto-pts/auto-pts/issues/740
GAP GAP/PADV/PASE/BV-05-C BTP ERROR - ERRATA https://github:com/auto-pts/auto-pts/issues/740
GAP GAP/PADV/PASE/BV-06-C BTP ERROR - ERRATA https://github:com/auto-pts/auto-pts/issues/740
GAP GAP/PADV/PAST/BV-01-C BTP ERROR - ERRATA https://github:com/auto-pts/auto-pts/issues/740
GAP GAP/PADV/PAST/BV-02-C BTP ERROR - ERRATA https://github:com/auto-pts/auto-pts/issues/740
GAP GAP/GAT/BV-04-C BTP ERROR
GAP GAP/GAT/BV-05-C BTP ERROR
GAP GAP/GAT/BV-06-C BTP ERROR
GAP GAP/BROB/BCST/BV-03-C BTP ERROR
GAP GAP/CONN/ACEP/BV-03-C BTP ERROR
GAP GAP/CONN/ACEP/BV-04-C BTP ERROR
GAP GAP/CONN/DCEP/BV-05-C BTP ERROR
GAP GAP/CONN/DCEP/BV-06-C BTP ERROR
GAP GAP/CONN/GCEP/BV-05-C BTP ERROR
GAP GAP/CONN/GCEP/BV-06-C BTP ERROR
GAP GAP/CONN/SCEP/BV-03-C BTP ERROR
GAP GAP/CONN/UCON/BV-06-C BTP ERROR
GAP GAP/DISC/GENM/BV-03-C BTP ERROR
GAP GAP/PRIV/CONN/BV-10-C BTP ERROR

@KKopyscinski
apps/bttester: drop glue module
f69eb88 
There is no need to be dependent on `glue` module and it can be dropped
from application. Mesh part of bttester can still use one from
`"mesh/glue.h"`
@KKopyscinski
apps/bttester: drop atomic.h
741a3be 
There is no need of porting extra atomic API in tester.
@KKopyscinski
apps/bttester: use ble_addr_t whenever possible
7bccd88 
We should use ble_addr_t instead of pair {address_type, address}
whenever possible, as suggested in 35c71a4

This simplifies code to single memcpy.
@KKopyscinski
apps/bttester: refactor GATT service
f024971 
Accomodated to new API.
@sjanc
Copy link
Contributor

sjanc commented Jul 21, 2023

#AutoPTS run mynewt GAP SM

@codecoup-tester
Copy link

Scheduled PR ##1543 (comment) after 09:21:37.

@codecoup-tester
Copy link

AutoPTS Bot results:

Failed testsGAP GAP/BROB/BCST/BV-01-C BTP ERROR
GAP GAP/BROB/BCST/BV-02-C BTP ERROR
GAP GAP/BROB/OBSV/BV-01-C BTP ERROR
GAP GAP/BROB/OBSV/BV-02-C BTP ERROR
GAP GAP/BROB/OBSV/BV-05-C BTP ERROR
GAP GAP/BROB/OBSV/BV-06-C BTP ERROR
GAP GAP/DISC/NONM/BV-01-C BTP ERROR
GAP GAP/DISC/NONM/BV-02-C BTP ERROR
GAP GAP/DISC/LIMM/BV-03-C BTP ERROR
GAP GAP/DISC/LIMM/BV-04-C BTP ERROR
GAP GAP/DISC/GENM/BV-04-C BTP ERROR
GAP GAP/DISC/LIMP/BV-01-C BTP ERROR
GAP GAP/DISC/LIMP/BV-02-C BTP ERROR
GAP GAP/DISC/LIMP/BV-03-C BTP ERROR
GAP GAP/DISC/LIMP/BV-04-C BTP ERROR
GAP GAP/DISC/LIMP/BV-05-C BTP ERROR
GAP GAP/DISC/GENP/BV-01-C BTP ERROR
GAP GAP/DISC/GENP/BV-02-C BTP ERROR
GAP GAP/DISC/GENP/BV-03-C BTP ERROR
GAP GAP/DISC/GENP/BV-04-C BTP ERROR
GAP GAP/DISC/GENP/BV-05-C BTP ERROR
GAP GAP/DISC/RPA/BV-01-C BTP ERROR
GAP GAP/IDLE/NAMP/BV-01-C BTP ERROR
GAP GAP/IDLE/NAMP/BV-02-C BTP ERROR
GAP GAP/CONN/NCON/BV-01-C BTP ERROR
GAP GAP/CONN/NCON/BV-02-C BTP ERROR
GAP GAP/CONN/NCON/BV-03-C BTP ERROR
GAP GAP/CONN/DCON/BV-01-C BTP ERROR
GAP GAP/CONN/UCON/BV-01-C BTP ERROR
GAP GAP/CONN/UCON/BV-02-C BTP ERROR
GAP GAP/CONN/UCON/BV-03-C BTP ERROR
GAP GAP/CONN/ACEP/BV-01-C BTP ERROR
GAP GAP/CONN/GCEP/BV-01-C BTP ERROR
GAP GAP/CONN/GCEP/BV-02-C BTP ERROR
GAP GAP/CONN/SCEP/BV-01-C BTP ERROR
GAP GAP/CONN/DCEP/BV-01-C BTP ERROR
GAP GAP/CONN/DCEP/BV-03-C BTP ERROR
GAP GAP/CONN/CPUP/BV-04-C BTP ERROR
GAP GAP/CONN/CPUP/BV-05-C BTP ERROR
GAP GAP/CONN/CPUP/BV-08-C BTP ERROR
GAP GAP/CONN/CPUP/BV-10-C BTP ERROR
GAP GAP/CONN/TERM/BV-01-C BTP ERROR
GAP GAP/CONN/PRDA/BV-01-C BTP ERROR
GAP GAP/CONN/PRDA/BV-02-C BTP ERROR
GAP GAP/BOND/NBON/BV-01-C BTP ERROR
GAP GAP/BOND/NBON/BV-02-C BTP ERROR
GAP GAP/BOND/NBON/BV-03-C BTP ERROR
GAP GAP/BOND/BON/BV-01-C BTP ERROR
GAP GAP/BOND/BON/BV-02-C BTP ERROR
GAP GAP/BOND/BON/BV-03-C BTP ERROR
GAP GAP/SEC/AUT/BV-11-C BTP ERROR
GAP GAP/SEC/AUT/BV-12-C BTP ERROR
GAP GAP/SEC/AUT/BV-13-C BTP ERROR
GAP GAP/SEC/AUT/BV-14-C BTP ERROR
GAP GAP/SEC/AUT/BV-17-C BTP ERROR
GAP GAP/SEC/AUT/BV-18-C BTP ERROR
GAP GAP/SEC/AUT/BV-19-C BTP ERROR
GAP GAP/SEC/AUT/BV-20-C BTP ERROR
GAP GAP/SEC/AUT/BV-21-C BTP ERROR
GAP GAP/SEC/AUT/BV-22-C BTP ERROR
GAP GAP/SEC/AUT/BV-23-C BTP ERROR
GAP GAP/SEC/AUT/BV-24-C BTP ERROR
GAP GAP/SEC/AUT/BV-25-C BTP ERROR
GAP GAP/SEC/AUT/BV-27-C BTP ERROR
GAP GAP/PRIV/CONN/BV-12-C BTP ERROR
GAP GAP/ADV/BV-01-C BTP ERROR
GAP GAP/ADV/BV-02-C BTP ERROR
GAP GAP/ADV/BV-03-C BTP ERROR
GAP GAP/ADV/BV-04-C BTP ERROR
GAP GAP/ADV/BV-05-C BTP ERROR
GAP GAP/ADV/BV-08-C BTP ERROR
GAP GAP/ADV/BV-10-C BTP ERROR
GAP GAP/ADV/BV-11-C BTP ERROR
GAP GAP/ADV/BV-14-C BTP ERROR
GAP GAP/ADV/BV-17-C BTP ERROR
GAP GAP/ADV/BV-18-C BTP ERROR
GAP GAP/PADV/PASM/BV-01-C BTP ERROR - ERRATA https://github:com/auto-pts/auto-pts/issues/740
GAP GAP/PADV/PAM/BV-01-C BTP ERROR - ERRATA https://github:com/auto-pts/auto-pts/issues/740
GAP GAP/PADV/PASE/BV-01-C BTP ERROR - ERRATA https://github:com/auto-pts/auto-pts/issues/740
GAP GAP/PADV/PASE/BV-02-C BTP ERROR - ERRATA https://github:com/auto-pts/auto-pts/issues/740
GAP GAP/PADV/PASE/BV-03-C BTP ERROR - ERRATA https://github:com/auto-pts/auto-pts/issues/740
GAP GAP/PADV/PASE/BV-04-C BTP ERROR - ERRATA https://github:com/auto-pts/auto-pts/issues/740
GAP GAP/PADV/PASE/BV-05-C BTP ERROR - ERRATA https://github:com/auto-pts/auto-pts/issues/740
GAP GAP/PADV/PASE/BV-06-C BTP ERROR - ERRATA https://github:com/auto-pts/auto-pts/issues/740
GAP GAP/PADV/PAST/BV-01-C BTP ERROR - ERRATA https://github:com/auto-pts/auto-pts/issues/740
GAP GAP/PADV/PAST/BV-02-C BTP ERROR - ERRATA https://github:com/auto-pts/auto-pts/issues/740
GAP GAP/GAT/BV-04-C BTP ERROR
GAP GAP/GAT/BV-05-C BTP ERROR
GAP GAP/GAT/BV-06-C BTP ERROR
Successful testsSM SM/CEN/PROT/BV-01-C PASS
SM SM/CEN/JW/BV-05-C PASS
SM SM/CEN/JW/BI-04-C PASS
SM SM/CEN/JW/BI-01-C PASS
SM SM/CEN/PKE/BV-01-C PASS
SM SM/CEN/PKE/BV-04-C PASS
SM SM/CEN/PKE/BI-01-C PASS
SM SM/CEN/PKE/BI-02-C PASS
SM SM/CEN/OOB/BV-01-C PASS
SM SM/CEN/OOB/BV-03-C PASS
SM SM/CEN/OOB/BV-09-C PASS

@sjanc
Copy link
Contributor

sjanc commented Jul 25, 2023

#AutoPTS run mynewt L2CAP MESH

@codecoup-tester
Copy link

Scheduled PR ##1543 (comment) after 08:58:33.

@codecoup-tester
Copy link

Scheduled PR ##1543 (comment) after 13:20:41.

@codecoup-tester
Copy link

Scheduled PR ##1543 (comment) after 13:23:28.

@codecoup-tester
Copy link

AutoPTS Bot results:

Failed testsL2CAP L2CAP/COS/CFC/BV-05-C BTP ERROR
L2CAP L2CAP/LE/CFC/BV-06-C BTP ERROR
L2CAP L2CAP/LE/CFC/BV-29-C BTP ERROR
L2CAP L2CAP/ECFC/BV-23-C INCONC
L2CAP L2CAP/ECFC/BV-29-C BTP ERROR
L2CAP L2CAP/ECFC/BV-38-C FAIL
L2CAP L2CAP/ECFC/BV-43-C INCONC - ERRATA TSE18351
L2CAP L2CAP/ECFC/BV-44-C FAIL - ERRATA TSE18351
MESH MESH/NODE/PBADV/BV-01-C BTP ERROR
MESH MESH/NODE/PBADV/BV-02-C BTP ERROR
MESH MESH/NODE/PBADV/BV-03-C BTP ERROR
MESH MESH/NODE/PBADV/BV-04-C BTP ERROR
MESH MESH/NODE/PBADV/BI-01-C BTP ERROR
MESH MESH/NODE/PBADV/BI-02-C BTP ERROR
MESH MESH/NODE/PBADV/BI-03-C BTP ERROR
Successful testsL2CAP L2CAP/COS/CFC/BV-01-C PASS
L2CAP L2CAP/COS/CFC/BV-02-C PASS
L2CAP L2CAP/COS/CFC/BV-03-C PASS
L2CAP L2CAP/COS/CFC/BV-04-C PASS
L2CAP L2CAP/COS/ECFC/BV-01-C PASS
L2CAP L2CAP/COS/ECFC/BV-02-C PASS
L2CAP L2CAP/COS/ECFC/BV-03-C PASS
L2CAP L2CAP/LE/CPU/BV-02-C PASS
L2CAP L2CAP/LE/CPU/BI-01-C PASS
L2CAP L2CAP/LE/CPU/BI-02-C PASS
L2CAP L2CAP/LE/REJ/BI-01-C PASS
L2CAP L2CAP/LE/REJ/BI-02-C PASS
L2CAP L2CAP/LE/CFC/BV-01-C PASS
L2CAP L2CAP/LE/CFC/BV-02-C PASS
L2CAP L2CAP/LE/CFC/BV-03-C PASS
L2CAP L2CAP/LE/CFC/BV-04-C PASS
L2CAP L2CAP/LE/CFC/BV-05-C PASS
L2CAP L2CAP/LE/CFC/BV-07-C PASS
L2CAP L2CAP/LE/CFC/BI-01-C PASS
L2CAP L2CAP/LE/CFC/BV-08-C PASS
L2CAP L2CAP/LE/CFC/BV-09-C PASS
L2CAP L2CAP/LE/CFC/BV-10-C PASS
L2CAP L2CAP/LE/CFC/BV-11-C PASS
L2CAP L2CAP/LE/CFC/BV-12-C PASS
L2CAP L2CAP/LE/CFC/BV-13-C PASS
L2CAP L2CAP/LE/CFC/BV-14-C PASS
L2CAP L2CAP/LE/CFC/BV-15-C PASS
L2CAP L2CAP/LE/CFC/BV-16-C PASS
L2CAP L2CAP/LE/CFC/BV-18-C PASS
L2CAP L2CAP/LE/CFC/BV-19-C PASS
L2CAP L2CAP/LE/CFC/BV-20-C PASS
L2CAP L2CAP/LE/CFC/BV-21-C PASS
L2CAP L2CAP/LE/CFC/BV-22-C PASS
L2CAP L2CAP/LE/CFC/BV-23-C PASS
L2CAP L2CAP/LE/CFC/BV-24-C PASS
L2CAP L2CAP/LE/CFC/BV-25-C PASS
L2CAP L2CAP/LE/CFC/BV-26-C PASS
L2CAP L2CAP/LE/CFC/BV-27-C PASS
L2CAP L2CAP/LE/CFC/BV-28-C PASS
L2CAP L2CAP/LE/CFC/BV-30-C PASS
L2CAP L2CAP/LE/CFC/BV-31-C PASS
L2CAP L2CAP/LE/CFC/BI-02-C PASS
L2CAP L2CAP/LE/CID/BI-01-C PASS
L2CAP L2CAP/ECFC/BV-01-C PASS
L2CAP L2CAP/ECFC/BV-02-C PASS
L2CAP L2CAP/ECFC/BV-03-C PASS
L2CAP L2CAP/ECFC/BV-04-C PASS
L2CAP L2CAP/ECFC/BV-06-C PASS (2)
L2CAP L2CAP/ECFC/BV-07-C PASS
L2CAP L2CAP/ECFC/BI-01-C PASS
L2CAP L2CAP/ECFC/BI-02-C PASS
L2CAP L2CAP/ECFC/BV-08-C PASS
L2CAP L2CAP/ECFC/BV-09-C PASS
L2CAP L2CAP/ECFC/BV-10-C PASS
L2CAP L2CAP/ECFC/BV-11-C PASS
L2CAP L2CAP/ECFC/BV-12-C PASS
L2CAP L2CAP/ECFC/BV-13-C PASS
L2CAP L2CAP/ECFC/BV-14-C PASS
L2CAP L2CAP/ECFC/BV-15-C PASS
L2CAP L2CAP/ECFC/BV-16-C PASS
L2CAP L2CAP/ECFC/BV-17-C PASS
L2CAP L2CAP/ECFC/BV-18-C PASS
L2CAP L2CAP/ECFC/BV-19-C PASS
L2CAP L2CAP/ECFC/BV-20-C PASS
L2CAP L2CAP/ECFC/BV-21-C PASS
L2CAP L2CAP/ECFC/BV-22-C PASS
L2CAP L2CAP/ECFC/BI-03-C PASS
L2CAP L2CAP/ECFC/BV-24-C PASS
L2CAP L2CAP/ECFC/BV-25-C PASS
L2CAP L2CAP/ECFC/BI-04-C PASS
L2CAP L2CAP/ECFC/BV-26-C PASS
L2CAP L2CAP/ECFC/BV-27-C PASS
L2CAP L2CAP/ECFC/BV-28-C PASS
L2CAP L2CAP/ECFC/BV-30-C PASS
L2CAP L2CAP/ECFC/BV-31-C PASS
L2CAP L2CAP/ECFC/BV-32-C PASS
L2CAP L2CAP/ECFC/BV-33-C PASS
L2CAP L2CAP/ECFC/BV-34-C PASS
L2CAP L2CAP/ECFC/BV-35-C PASS
L2CAP L2CAP/ECFC/BV-39-C PASS
L2CAP L2CAP/ECFC/BV-41-C PASS
L2CAP L2CAP/ECFC/BI-05-C PASS
L2CAP L2CAP/ECFC/BI-06-C PASS
L2CAP L2CAP/ECFC/BI-07-C PASS
L2CAP L2CAP/ECFC/BI-08-C PASS

@KKopyscinski KKopyscinski force-pushed the btp_refactor branch 2 times, most recently from 2a0290c to 08250e0 Compare July 26, 2023 07:05
@KKopyscinski
apps/bttester: refactor L2CAP service
4dc2cb4 
Accomodated to new API.
@KKopyscinski
apps/bttester: refactor Mesh service
e783ab0 
Accomodate to new API.
@KKopyscinski
apps/bttester: refactor GATT Client service
d882f43 
Accomodated to new API.
@KKopyscinski
apps/bttester: Keep BTP command in buffer for delayed response
e822272 
This allows to avoid copying data for async callbacks.
@KKopyscinski
bluetooth: tester: Add explicit functions for event and response
ffdb1f0 
This make is easier to verify if proper use of BTP is maintained.
tester_rsp and tester_rsp_full will be removed eventually when
BTP is fully async.
@KKopyscinski
bluetooth: tester: Use define for variable length BTP commands
aa409e7 
This makes code a bit easier to follow.
@sjanc
Copy link
Contributor

sjanc commented Jul 26, 2023

#AutoPTS run mynewt MESH

@codecoup-tester
Copy link

Scheduled PR ##1543 (comment) after 12:58:32.

@codecoup-tester
Copy link

AutoPTS Bot results:

Failed testsMESH MESH/NODE/MPS/BI-01-C BTP ERROR
MESH MESH/NODE/NET/BV-02-C BTP ERROR
MESH MESH/NODE/NET/BV-09-C BTP ERROR
MESH MESH/NODE/NET/BI-02-C BTP ERROR
MESH MESH/NODE/TNPT/BV-05-C BTP ERROR
MESH MESH/NODE/IVU/BV-04-C INCONC
MESH MESH/NODE/IVU/BI-06-C FAIL
Successful testsMESH MESH/NODE/PBADV/BV-01-C PASS
MESH MESH/NODE/PBADV/BV-02-C PASS
MESH MESH/NODE/PBADV/BV-03-C PASS
MESH MESH/NODE/PBADV/BV-04-C PASS
MESH MESH/NODE/PBADV/BI-01-C PASS
MESH MESH/NODE/PBADV/BI-02-C PASS
MESH MESH/NODE/PBADV/BI-03-C PASS
MESH MESH/NODE/PBADV/BI-04-C PASS
MESH MESH/NODE/MPS/BV-01-C PASS
MESH MESH/NODE/MPS/BV-02-C PASS
MESH MESH/NODE/MPS/BV-03-C PASS
MESH MESH/NODE/MPS/BV-04-C PASS
MESH MESH/NODE/MPS/BV-05-C PASS
MESH MESH/NODE/MPS/BV-06-C PASS
MESH MESH/NODE/MPS/BV-07-C PASS
MESH MESH/NODE/MPS/BV-08-C PASS
MESH MESH/NODE/MPS/BV-09-C PASS
MESH MESH/NODE/MPS/BV-10-C PASS
MESH MESH/NODE/PROV/BV-01-C PASS
MESH MESH/NODE/PROV/BV-07-C PASS
MESH MESH/NODE/PROV/BV-09-C PASS
MESH MESH/NODE/PROV/BV-10-C PASS
MESH MESH/NODE/PROV/BV-11-C PASS
MESH MESH/NODE/PROV/BV-12-C PASS
MESH MESH/NODE/PROV/BI-01-C PASS
MESH MESH/NODE/PROV/BI-02-C PASS
MESH MESH/NODE/PROV/BI-03-C PASS
MESH MESH/NODE/PROV/BI-13-C PASS
MESH MESH/NODE/PROV/BI-15-C PASS
MESH MESH/NODE/PROV/BI-17-C PASS
MESH MESH/NODE/BCN/SNB/BV-01-C PASS
MESH MESH/NODE/NET/BV-01-C PASS
MESH MESH/NODE/NET/BV-03-C PASS
MESH MESH/NODE/NET/BV-04-C PASS
MESH MESH/NODE/NET/BV-05-C PASS
MESH MESH/NODE/NET/BV-06-C PASS
MESH MESH/NODE/NET/BV-07-C PASS
MESH MESH/NODE/NET/BV-08-C PASS
MESH MESH/NODE/NET/BV-10-C PASS
MESH MESH/NODE/NET/BV-11-C PASS
MESH MESH/NODE/NET/BV-12-C PASS
MESH MESH/NODE/NET/BV-13-C PASS
MESH MESH/NODE/NET/BV-14-C PASS
MESH MESH/NODE/NET/BI-01-C PASS
MESH MESH/NODE/NET/BI-03-C PASS
MESH MESH/NODE/RLY/BV-01-C PASS
MESH MESH/NODE/RLY/BV-02-C PASS
MESH MESH/NODE/RLY/BI-01-C PASS
MESH MESH/NODE/RLY/BI-02-C PASS
MESH MESH/NODE/TNPT/BV-01-C PASS
MESH MESH/NODE/TNPT/BV-02-C PASS
MESH MESH/NODE/TNPT/BV-03-C PASS
MESH MESH/NODE/TNPT/BV-04-C PASS
MESH MESH/NODE/TNPT/BV-06-C PASS
MESH MESH/NODE/TNPT/BV-07-C PASS
MESH MESH/NODE/TNPT/BV-08-C PASS
MESH MESH/NODE/TNPT/BV-09-C PASS
MESH MESH/NODE/TNPT/BV-10-C PASS
MESH MESH/NODE/TNPT/BV-11-C PASS
MESH MESH/NODE/TNPT/BV-12-C PASS
MESH MESH/NODE/TNPT/BV-13-C PASS
MESH MESH/NODE/TNPT/BI-01-C PASS
MESH MESH/NODE/TNPT/BI-02-C PASS
MESH MESH/NODE/IVU/BV-01-C PASS
MESH MESH/NODE/IVU/BV-02-C PASS
MESH MESH/NODE/IVU/BV-03-C PASS
MESH MESH/NODE/IVU/BV-05-C PASS (2)
MESH MESH/NODE/IVU/BI-01-C PASS
MESH MESH/NODE/IVU/BI-02-C PASS
MESH MESH/NODE/IVU/BI-04-C PASS
MESH MESH/NODE/IVU/BI-05-C PASS
MESH MESH/NODE/KR/BV-01-C PASS
MESH MESH/NODE/KR/BV-02-C PASS
MESH MESH/NODE/KR/BV-03-C PASS
MESH MESH/NODE/KR/BI-01-C PASS
MESH MESH/NODE/KR/BI-02-C PASS
MESH MESH/NODE/KR/BI-03-C PASS
MESH MESH/NODE/KR/BI-04-C PASS
MESH MESH/NODE/KR/BI-05-C PASS
MESH MESH/NODE/FRND/FN/BV-01-C PASS
MESH MESH/NODE/FRND/FN/BV-02-C PASS
MESH MESH/NODE/FRND/FN/BV-03-C PASS
MESH MESH/NODE/FRND/FN/BV-04-C PASS
MESH MESH/NODE/FRND/FN/BV-05-C PASS
MESH MESH/NODE/FRND/FN/BV-06-C PASS
MESH MESH/NODE/FRND/FN/BV-07-C PASS
MESH MESH/NODE/FRND/FN/BV-08-C PASS
MESH MESH/NODE/FRND/FN/BV-09-C PASS
MESH MESH/NODE/FRND/FN/BV-10-C PASS
MESH MESH/NODE/FRND/FN/BV-11-C PASS
MESH MESH/NODE/FRND/FN/BV-12-C PASS
MESH MESH/NODE/FRND/FN/BV-13-C PASS
MESH MESH/NODE/FRND/FN/BV-14-C PASS

@sjanc sjanc merged commit e2065a6 into apache:master Jul 26, 2023
8 checks passed
@KKopyscinski KKopyscinski deleted the btp_refactor branch February 13, 2024 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sjanc sjanc sjanc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@KKopyscinski @sjanc @codecoup-tester