nimble: Eatt initial implementation #1549

KKopyscinski · 2023-07-13T10:44:07Z

This is rebased #773

Before merging this needs to be checked against specification and tested

KKopyscinski · 2023-07-17T11:07:06Z

TODO: it may be worth checking client_att_busy flag reset after disconnection. Because ble_gatt_conn_test_disconnect tests only GATT API for broken connection (connection instance still exists) it probably should be done as separate test, maybe in GAP.

rymanluk · 2023-07-18T07:35:05Z

nimble/host/src/ble_hs.c

@@ -734,6 +734,9 @@ ble_hs_init(void)
    rc = ble_l2cap_init();
    SYSINIT_PANIC_ASSERT(rc == 0);

+    rc = ble_gap_init();


we need to do something with line 752 I guess

Also, ble_gap_init should be outside #if NIMBLE_BLE_CONNECT - it includes code for features without connection

rymanluk · 2023-07-18T07:37:53Z

nimble/host/src/ble_att_cmd.c


+#if MYNEWT_VAL(BLE_EATT_CHAN_NUM) > 0
+    if (cid != BLE_L2CAP_CID_ATT) {
+        return ble_eatt_tx(conn_handle, cid, txom);


this part should be in following patch I guess

KKopyscinski · 2023-07-21T08:11:50Z

Found bug in Read Multiple Variable Length handling: implementation is OK, but btshell must be changed.
Code seems copied from other read/write callbacks, but here format is different. Response is single message with multiple tuples of {length, value} pairs, that is up to MTU in size. If more should be returned, it's trimmed: so we don't use BLE_HS_EDONE to mark final message, we will receive only one, with success code of 0. struct ble_gatt_attr *attr points to the first attreibute in list, and num_handles must be used to access the rest

edit: on the other hand, current implementation in shell expects we continue reading via Read Long procedure, and mark end of it with BLE_HS_EDONE. So implementing this behavior might be beneficial (if rsp buffer is full ocntinue reading until read < MTU -1)

KKopyscinski · 2023-08-04T11:18:39Z

This was tested against PTS and implemented features are passing. After rebase some commits were added and some modified. Changes between rebase and current version can be seen here: https://gist.github.com/KKopyscinski/5ed12fe57bb457f21a8d98d2a84e0406
rebased version without these changes is here https://github.com/KKopyscinski/mynewt-nimble/tree/eatt_initial_rebase

TODO: Add support for sending Multiple Handle Variable Length Notification.

This is needed as eatt is registering listener in gap nowadays

This patch adds CID to the data path for all the GATT operations. It also updates unit tests after the change.

The idea for EATT in Mynewt is as follow. EATT is not exposed to the user i.e. GATT API stays the same. User can define number of EATT channels supported by the host and it is host managing those channels. EATT will be fist choice channel for every ATT operation. In the future we can make it smarted and make a choice based on the ATT data in the packet TODO: * handle reading and setting client/server Supported features in the stack instead of eatt code * add test API to choose channel to use (needed by PTS)

This is initial implementation of handling new GATT opcodes. Gatt Client supports now: ATT multi Variable read req receiving ATT multi notifications Gatt server supports now: ATT multi Variable read rsp

In real case, requests are scheduled to be sent after previous one completes. That happens after response is received. In unittests, internal API is used for holding pending requests, from which they can be manually dequeued. Because dequeue operation is always manual and does not happed after response reception (when will never arrive, there is no second device) we need to clear flag to be able to start another procedure.

This is needed to properly handle failed procedure, and pass error to the app.

This was missing and assert in ble_eatt_l2cap_event_fn was hit

Adds required command and response event.

GATT Client by writing to Client Supported Features characteristic reports to server what features it supports. These features should be saved for future use so appropriate subprocedures can be selected.

Channel was taken and function returns before release.

Assert was hit when BLE_ATT_OP_NOTIFY_MULTI_REQ was received.

…config EATT supported bit is returned when EATT channel number is greater than 0 and Multiple Handle notification based on BLE_ATT_SVR_NOTIFY_MULTI.

For EATT bearer, ATT MTU is same for bot RX and TX and is minimum of the two. L2CAP Credit Based Reconfigure Request can be used to change its value.

Added check for link encryption. Removed unused flags for client/server process. Before processing it is checked if PDU is an ATT one, and channel is disconnected if not. If after processing PDU next one can't be received link is discconnected.

rymanluk · 2023-08-24T08:33:42Z

Looks like it was merged accidentally but if all is working then it is fine. I was about to approve it anyways.

KKopyscinski force-pushed the eatt-initial branch 6 times, most recently from 7b12d91 to 7720d63 Compare July 17, 2023 10:39

KKopyscinski requested a review from rymanluk July 17, 2023 10:40

KKopyscinski force-pushed the eatt-initial branch 2 times, most recently from 65d2699 to 879f76b Compare July 17, 2023 11:05

rymanluk reviewed Jul 18, 2023

View reviewed changes

KKopyscinski force-pushed the eatt-initial branch from 879f76b to 719026a Compare July 19, 2023 08:04

KKopyscinski force-pushed the eatt-initial branch 2 times, most recently from f427590 to dc58881 Compare July 27, 2023 06:52

KKopyscinski mentioned this pull request Aug 4, 2023

NimBLE/Host: Feature Multi Handle Value Notification #1426

Open

KKopyscinski requested a review from rymanluk August 4, 2023 11:18

KKopyscinski changed the title ~~nimble: [WIP] Eatt initial implementation~~ nimble: Eatt initial implementation Aug 4, 2023

KKopyscinski marked this pull request as ready for review August 4, 2023 11:19

KKopyscinski requested a review from sjanc August 4, 2023 11:30

KKopyscinski force-pushed the eatt-initial branch from bd5aeaf to 68513ce Compare August 4, 2023 11:34

This was referenced Aug 4, 2023

BTtester accomodated to EATT testing #845

Closed

nimble: [WIP] Eatt initial implementation #773

Closed

rymanluk added 2 commits August 7, 2023 08:32

nimble/host: Make gap init before att

301c0cb

This is needed as eatt is registering listener in gap nowadays

nimble/gatt: Prepare GATT for EATT

ab32156

This patch adds CID to the data path for all the GATT operations. It also updates unit tests after the change.

KKopyscinski force-pushed the eatt-initial branch from 68513ce to d0dd7d1 Compare August 7, 2023 10:28

KKopyscinski force-pushed the eatt-initial branch from 5600f01 to aee619f Compare August 22, 2023 06:43

rymanluk and others added 12 commits August 22, 2023 08:52

nimble/gatt: Add support for newt ATT opcodes

6588e13

This is initial implementation of handling new GATT opcodes. Gatt Client supports now: ATT multi Variable read req receiving ATT multi notifications Gatt server supports now: ATT multi Variable read rsp

btshell: Add support for read multi variable

d093078

host: add error handler cb for Read Multiple Variable Length

32addcb

This is needed to properly handle failed procedure, and pass error to the app.

host/ble_att.c: add missing op code for BLE_ATT_OP_READ_MULT_VAR REQ/RSP

a8fea85

This was missing and assert in ble_eatt_l2cap_event_fn was hit

apps/bttester: add support for GATT Read Multiple Variable Length

777be1e

Adds required command and response event.

host/gatts: save reported Client Supported Features per connection

ff66d04

GATT Client by writing to Client Supported Features characteristic reports to server what features it supports. These features should be saved for future use so appropriate subprocedures can be selected.

host/ble_att_ctl.c: release eatt chan in ble_att_clt_tx_notify

be57139

Channel was taken and function returns before release.

host/ble_att.c: add missing OP code in ble_att_is_request_op

2962025

Assert was hit when BLE_ATT_OP_NOTIFY_MULTI_REQ was received.

host/ble_svc_gatt.c: return local Client supported features based on …

ca01e57

…config EATT supported bit is returned when EATT channel number is greater than 0 and Multiple Handle notification based on BLE_ATT_SVR_NOTIFY_MULTI.

host/ble_att.c: fix ATT MTU for EATT channels

38e56a7

For EATT bearer, ATT MTU is same for bot RX and TX and is minimum of the two. L2CAP Credit Based Reconfigure Request can be used to change its value.

host/ble_eatt: improve PDU rx management

93aae47

Added check for link encryption. Removed unused flags for client/server process. Before processing it is checked if PDU is an ATT one, and channel is disconnected if not. If after processing PDU next one can't be received link is discconnected.

KKopyscinski force-pushed the eatt-initial branch from aee619f to 93aae47 Compare August 22, 2023 06:52

host/ble_att_svr.c: handle errors in ble_att_svr_rx_notify_multi

1fb6ee0

KKopyscinski merged commit 10b3aa0 into apache:master Aug 24, 2023
7 of 8 checks passed

KKopyscinski deleted the eatt-initial branch February 13, 2024 07:55

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

nimble: Eatt initial implementation #1549

nimble: Eatt initial implementation #1549

KKopyscinski commented Jul 13, 2023

KKopyscinski commented Jul 17, 2023

rymanluk Jul 18, 2023

KKopyscinski Jul 19, 2023

KKopyscinski Jul 19, 2023

rymanluk Jul 18, 2023

KKopyscinski Jul 19, 2023

KKopyscinski commented Jul 21, 2023 •

edited

Loading

KKopyscinski commented Aug 4, 2023

rymanluk commented Aug 24, 2023

nimble: Eatt initial implementation #1549

nimble: Eatt initial implementation #1549

Conversation

KKopyscinski commented Jul 13, 2023

KKopyscinski commented Jul 17, 2023

rymanluk Jul 18, 2023

Choose a reason for hiding this comment

KKopyscinski Jul 19, 2023

Choose a reason for hiding this comment

KKopyscinski Jul 19, 2023

Choose a reason for hiding this comment

rymanluk Jul 18, 2023

Choose a reason for hiding this comment

KKopyscinski Jul 19, 2023

Choose a reason for hiding this comment

KKopyscinski commented Jul 21, 2023 • edited Loading

KKopyscinski commented Aug 4, 2023

rymanluk commented Aug 24, 2023

KKopyscinski commented Jul 21, 2023 •

edited

Loading