fix(nimble): Handled error return value while removing RPA list from … #1605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fanhang32
approved these changes
Sep 13, 2023
ESPAbhinav
force-pushed
the
bugfix/ble_gap_unpair
branch
from
2fb228f
to
7d90e5b
Compare
ESPAbhinav
force-pushed
the
bugfix/ble_gap_unpair
branch
from
7d90e5b
to
7310891
Compare
sjanc
reviewed
Sep 20, 2023
There was a problem hiding this comment.
Hi,
looks ok, just small nitpick about coding style
Also commit message should follow our convention, eg:
"nimble/host: Fix not handling error on RL element removal
If address resolution is enabled in controller it will reject
any RL modification. This could lead to leaving entry on RL
while removing bonding information"
| @@ -6060,8 +6061,11 @@ ble_gap_unpair(const ble_addr_t *peer_addr) | |||
|
|
|||
| ble_hs_unlock(); | |||
|
|
|||
| ble_hs_pvcy_remove_entry(peer_addr->type, | |||
| rc = ble_hs_pvcy_remove_entry(peer_addr->type, | |||
| peer_addr->val); | |||
sjanc
approved these changes
Oct 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To remove the device from the RPA List ble_gap_unpair() API is used which sends a command to the controller. This command shall not be used when address resolution is enabled in the
Controller and:
HCI_LE_Periodic_Advertising_Create_Sync command is pending.
An error check is added for the API
ble_hs_pvcy_remove_entrywhich is invoked byble_gap_unpair().