nimble/host: Initial Broadcast Source implementation #1619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rymanluk
reviewed
Sep 25, 2023
nimble/host/services/leaudio/broadcaster/include/leaudio/broadcaster/broadcaster.h
Outdated
Show resolved
Hide resolved
rymanluk
reviewed
Sep 25, 2023
nimble/host/services/leaudio/broadcaster/include/leaudio/broadcaster/broadcaster.h
Outdated
Show resolved
Hide resolved
rymanluk
reviewed
Sep 25, 2023
nimble/host/services/leaudio/broadcaster/include/leaudio/broadcaster/broadcaster.h
Outdated
Show resolved
Hide resolved
rymanluk
reviewed
Sep 25, 2023
rymanluk
reviewed
Sep 25, 2023
rymanluk
reviewed
Sep 25, 2023
KKopyscinski
force-pushed
the
auracast_api
branch
4 times, most recently
from
5899354
to
81f6bbb
Compare
KKopyscinski
changed the title
KKopyscinski
force-pushed
the
auracast_api
branch
4 times, most recently
from
72350c9
to
0c2229e
Compare
rymanluk
reviewed
Oct 2, 2023
rymanluk
reviewed
Oct 2, 2023
KKopyscinski
commented
Oct 2, 2023
KKopyscinski
commented
Oct 2, 2023
KKopyscinski
commented
Oct 2, 2023
KKopyscinski
commented
Oct 2, 2023
KKopyscinski
commented
Oct 2, 2023
KKopyscinski
commented
Oct 2, 2023
KKopyscinski
commented
Oct 2, 2023
KKopyscinski
commented
Oct 2, 2023
KKopyscinski
commented
Oct 2, 2023
KKopyscinski
commented
Oct 2, 2023
KKopyscinski
commented
Oct 2, 2023
KKopyscinski
force-pushed
the
auracast_api
branch
2 times, most recently
from
f437f26
to
8e39627
Compare
KKopyscinski
commented
Nov 20, 2023
|
|
||
| int | ||
| ble_svc_auracast_create(const struct ble_svc_auracast_create_params *params, | ||
| uint8_t *adv_instance, |
There was a problem hiding this comment.
auracast_instance (change name)
KKopyscinski
force-pushed
the
auracast_api
branch
8 times, most recently
from
2c1b5d1
to
71397f7
Compare
KKopyscinski
force-pushed
the
auracast_api
branch
3 times, most recently
from
e06b50d
to
b183928
Compare
This is a design of API that could be used to create BASE configuration manage its broadcast (setup extended advertising, periodic advertising and BASE advertisements, stop, resume, terminate and modify them)
This patch implements Broadcast feature in host. It includes implementation of ISO in host, with application API, HCI commands and ISO event handling. Host is now capable of managing BIGs with subgroups and BISes, updating Broadcast announcements and pushing data to ISO, to send in BIS events. Maximum extended advertising size was set to 251 to fit Periodic advertising data connected with Broadcast Audio Announcement Service advertisements by default. This patch does not implement Broadcast sink, only source.
This patch adds commands to btshell to allow creating BIGs, BIG subgroups and BISe and create and manage Broadcast advertisements.
ble_gap_adv_get_free_instance browses through list of advertising instances and returns first that is not yet configured. Previously, user had to track which instance is used by themselves, and could only check if advertising is active, via ble_gap_ext_adv_active
This is simplified wrapper for Broadcast, that allows to create Broadcast advertisements with sane defaults for advertising parameters. Application still needs to build BASE configuration to use it.
KKopyscinski
force-pushed
the
auracast_api
branch
3 times, most recently
from
a39a7cc
to
322a9a8
Compare
Added application that has stored LC3 coded audio in form of sine sweep from 100Hz to 20kHz. Application creates Broadcast announcement, builds BIG with 1 or 2 BISes and starts to broadcast sample data.
This sample uses Auracast package to broadcast audio
KKopyscinski
force-pushed
the
auracast_api
branch
from
322a9a8
to
ccd52f9
Compare
sjanc
approved these changes
Dec 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is rough outline of API that could be used to create BASE configuration and start broadcast (setup extended advertising, periodic advertising and BASE advertisements)