nimble/host: Fix not catching conversion error in hex2bin #1625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hex2val returns BLE_HS_EINVAL on error which is positive value.
This could result in UUID conversion errors as hex2bin is used
by ble_uuid_from_str.
This was also causing build error with GCC 9:
repos/apache-mynewt-nimble/nimble/host/src/ble_uuid.c:76:28: error:
'tmp_val' may be used uninitialized in this function
[-Werror=maybe-uninitialized]
76 | bin[len] = tmp_val << 4;
| ~~~~~~~~^~~~
cc1: all warnings being treated as errors
|
@jrotkiewicz FYI |
|
fixes build issue from apache/mynewt-core#3015 |
andrzej-kaczmarek
approved these changes
Oct 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hex2val returns BLE_HS_EINVAL on error which is positive value. This could result in UUID conversion errors as hex2bin is used by ble_uuid_from_str.
This was also causing build error with GCC 9:
repos/apache-mynewt-nimble/nimble/host/src/ble_uuid.c:76:28: error:
'tmp_val' may be used uninitialized in this function
[-Werror=maybe-uninitialized]
76 | bin[len] = tmp_val << 4;
| ~~~~~~~~^~~~
cc1: all warnings being treated as errors