nimble/ll: Add vs hci to set local IRK #1630
Merged
+183
−30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrzej-kaczmarek
force-pushed
the
ll-rpa0-hack
branch
2 times, most recently
from
a3a4fbe
to
c3190d8
Compare
andrzej-kaczmarek
changed the title
andrzej-kaczmarek
force-pushed
the
ll-rpa0-hack
branch
from
c3190d8
to
53fe496
Compare
andrzej-kaczmarek
force-pushed
the
ll-rpa0-hack
branch
4 times, most recently
from
fe5dfea
to
5007196
Compare
sjanc
reviewed
Oct 5, 2023
| if (cmdlen != sizeof(*cmd)) { | ||
| return BLE_ERR_INV_HCI_CMD_PARMS; | ||
| } | ||
|
|
There was a problem hiding this comment.
we should probably disallow this when initiating and advertising (?) (connectable, undirected)
| #if MYNEWT_VAL(BLE_LL_HCI_VS_LOCAL_IRK) | ||
| int | ||
| ble_ll_resolv_local_irk_set(const uint8_t *irk) | ||
| { |
There was a problem hiding this comment.
use ble_ll_resolv_irk_nonzero()
| #if MYNEWT_VAL(BLE_LL_HCI_VS_LOCAL_IRK) | ||
| OS_ENTER_CRITICAL(sr); | ||
| if (g_local_irk.is_set) { | ||
| generate_rpa(g_local_irk.irk, g_local_irk.rpa); |
There was a problem hiding this comment.
RPA could be generated before critical section, and critical section could be only under if (as it may be cleared only from same task)
|
|
||
| #define BLE_HCI_OCF_VS_SET_LOCAL_IRK (MYNEWT_VAL(BLE_HCI_VS_OCF_OFFSET) + (0x000A)) | ||
| struct ble_hci_vs_set_local_irk_cp { | ||
| uint8_t irk[16]; |
There was a problem hiding this comment.
just a loose thought, maybe this could also have address type? public vs static_random
andrzej-kaczmarek
force-pushed
the
ll-rpa0-hack
branch
from
5007196
to
2cc91e0
Compare
This adds vendor-specific HCI command to set local IRK in controller. IRK can be set for both public and static random addresses separately. Local IRK, if set, is used to generate local RPA in use cases where own address type was set to 0x02 or 0x03 but peer address is not added to resolving list. This for example allows to handle initiating connection to a new peer using RPA as our local address entirely in LL. Without that command it would be required for host to generate an RPA, set it as random address and connect using random address. This however doesn't work well with NimBLE host. If no IRK is set (or set to all-zero), the controller behaves as usual which makes it safe to enable as it won't break anything.
andrzej-kaczmarek
force-pushed
the
ll-rpa0-hack
branch
from
2cc91e0
to
d706df7
Compare
sjanc
approved these changes
Oct 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds vendor-specific HCI command to set local IRK in controller.
Local IRK, if set, is used to generate local RPA in use cases where own address type was set to 0x02 or 0x03 but peer address is not added to resolving list. This for example allows to handle initiating connection to a new peer using RPA as our local address entirely in LL. Without that command it would be required for host to generate an RPA, set it as random address and connect using random address. This however doesn't work well with NimBLE host.
If no IRK is set (or set to all-zero), the controller behaves as usual which makes it safe to enable as it won't break anything.