nimble: add sysconfig for enabling additional PHYs #1646
Conversation
nimble/syscfg.yml
Outdated
| @@ -130,6 +130,25 @@ syscfg.defs: | |||
| This enables LE Connection Subrating feature | |||
| value: 0 | |||
|
|
|||
| BLE_ADDITIONAL_PHY: | |||
There was a problem hiding this comment.
I'd name it simply 'BLE_PHY'
There was a problem hiding this comment.
why do we need separate syscfg? just enable 2m or coded or both.
There was a problem hiding this comment.
It's because it may be simplier to cut down code if neither is supported. So when you check something besides 1M is supported you do
#if MYNEWT_VAL(BLE_PHY)
instead of
#if MYNEWT_VAL(BLE_PHY_2M) || MYNEWT_VAL(BLE_PHY_CODED)
There was a problem hiding this comment.
#define BLE_PHY_ENABLED (MYNEWT_VAL(BLE_PHY_2M) || MYNEWT_VAL(BLE_PHY_CODED))
...
#if BLE_PHY_ENABLED
#endif
alternatively smth like this should work
syscfg.defs.'BLE_PHY_2M || BLE_PHY_CODED':
BLE_PHY: 1
we should avoid syscfg vals that do nothing except they have to be set because another syscfg is set
There was a problem hiding this comment.
Makes sense to me, I updated PR with second option. Config generates OK
nimble/syscfg.yml
Outdated
| This enables support for addtitional PHY (2M or CODED) | ||
| value: 0 | ||
|
|
||
| BLE_2M_PHY: |
nimble/syscfg.yml
Outdated
| restrictions: | ||
| - 'BLE_ADDITIONAL_PHY if 1' | ||
|
|
||
| BLE_CODED_PHY: |
KKopyscinski
force-pushed
the
phy_config
branch
from
94adaf1
to
cb70800
Compare
Three new configs are introduced: BLE_ADDITIONAL_PHY that enables additional PHY and two configs that specify what additional PHY shall be enabled (2M or CODED)
KKopyscinski
force-pushed
the
phy_config
branch
from
cb70800
to
745b6e2
Compare
Added second commit |
| @@ -233,7 +233,7 @@ struct ble_ll_conn_sm | |||
| uint16_t host_req_max_rx_time; | |||
| #endif | |||
|
|
|||
| #if (BLE_LL_BT5_PHY_SUPPORTED == 1) | |||
| #if (MYNEWT_VAL(BLE_LL_PHY)) | |||
There was a problem hiding this comment.
remove extra parentheses
This config infers value from PHY flags and replaces BLE_LL_BT5_PHY_SUPPORTED define.
KKopyscinski
force-pushed
the
phy_config
branch
from
18c5e74
to
ec19ec7
Compare
Three new configs are introduced: BLE_ADDITIONAL_PHY that enables additional PHY and two configs that specify what additional PHY shall be enabled (2M or CODED)