-
Notifications
You must be signed in to change notification settings - Fork 399
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nimble/host: Add Broadcast Audio Scan Service #1691
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rymanluk
reviewed
Feb 11, 2024
nimble/host/services/audio/bass/include/services/bass/ble_audio_svc_bass.h
Outdated
Show resolved
Hide resolved
MariuszSkamra
suggested changes
Feb 27, 2024
nimble/host/services/audio/bass/include/services/bass/ble_audio_svc_bass.h
Outdated
Show resolved
Hide resolved
nimble/host/services/audio/bass/include/services/bass/ble_audio_svc_bass.h
Outdated
Show resolved
Hide resolved
nimble/host/services/audio/bass/include/services/bass/ble_audio_svc_bass.h
Outdated
Show resolved
Hide resolved
nimble/host/services/audio/bass/include/services/bass/ble_audio_svc_bass.h
Outdated
Show resolved
Hide resolved
nimble/host/services/audio/bass/include/services/bass/ble_audio_svc_bass.h
Outdated
Show resolved
Hide resolved
nimble/host/services/audio/bass/include/services/bass/ble_audio_svc_bass.h
Outdated
Show resolved
Hide resolved
nimble/host/services/audio/bass/include/services/bass/ble_audio_svc_bass.h
Outdated
Show resolved
Hide resolved
nimble/host/services/audio/bass/include/services/bass/ble_audio_svc_bass.h
Outdated
Show resolved
Hide resolved
nimble/host/services/audio/bass/include/services/bass/ble_audio_svc_bass.h
Outdated
Show resolved
Hide resolved
nimble/host/audio/services/bass/include/services/bass/ble_audio_svc_bass.h
Outdated
Show resolved
Hide resolved
KKopyscinski
commented
Mar 5, 2024
KKopyscinski
force-pushed
the
bass
branch
2 times, most recently
from
March 12, 2024 08:47
3c6aa65
to
a7c84ed
Compare
KKopyscinski
force-pushed
the
bass
branch
3 times, most recently
from
March 12, 2024 09:12
2bc5bf2
to
84a6111
Compare
KKopyscinski
force-pushed
the
bass
branch
7 times, most recently
from
March 25, 2024 08:32
4165900
to
b6f1be7
Compare
KKopyscinski
force-pushed
the
bass
branch
5 times, most recently
from
April 22, 2024 11:44
28d771f
to
b058658
Compare
nimble/host/audio/services/bass/include/services/bass/ble_audio_svc_bass.h
Show resolved
Hide resolved
nimble/host/audio/services/bass/include/services/bass/ble_audio_svc_bass.h
Show resolved
Hide resolved
nimble/host/audio/services/bass/include/services/bass/ble_audio_svc_bass.h
Show resolved
Hide resolved
nimble/host/audio/services/bass/include/services/bass/ble_audio_svc_bass.h
Outdated
Show resolved
Hide resolved
nimble/host/audio/services/bass/include/services/bass/ble_audio_svc_bass.h
Show resolved
Hide resolved
nimble/host/audio/services/bass/include/services/bass/ble_audio_svc_bass.h
Show resolved
Hide resolved
KKopyscinski
force-pushed
the
bass
branch
3 times, most recently
from
April 23, 2024 11:48
1aa22e9
to
1b013d3
Compare
MariuszSkamra
suggested changes
Apr 26, 2024
nimble/host/audio/services/bass/include/services/bass/ble_audio_svc_bass.h
Outdated
Show resolved
Hide resolved
nimble/host/audio/services/bass/include/services/bass/ble_audio_svc_bass.h
Outdated
Show resolved
Hide resolved
nimble/host/audio/services/bass/include/services/bass/ble_audio_svc_bass.h
Outdated
Show resolved
Hide resolved
nimble/host/audio/services/bass/include/services/bass/ble_audio_svc_bass.h
Outdated
Show resolved
Hide resolved
nimble/host/audio/services/bass/include/services/bass/ble_audio_svc_bass.h
Show resolved
Hide resolved
KKopyscinski
force-pushed
the
bass
branch
7 times, most recently
from
April 26, 2024 10:51
551220d
to
ffeaffa
Compare
BASS initial implementation
MariuszSkamra
approved these changes
Apr 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BASS initial implementation