ci: Fix Check ports syscfg update workflow #1716
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -58,15 +58,18 @@ jobs: | |||
| run: | | |||
| cd build | |||
| ./repos/apache-mynewt-nimble/porting/update_generated_files.sh | |||
| cd repos/apache-mynewt-nimble | |||
| cd .. | |||
There was a problem hiding this comment.
there's no point in changing working directory at the end of script
There was a problem hiding this comment.
Agreed, but that was what @sjanc suggested for this script to be more future-proof. Should I remove these 'cd's at the end of each step?
Changes the way 'cd' command is used, so it takes into account that each step is run in a separate shell instance.
wpiet
force-pushed
the
sysfg-check-ci-fix
branch
from
3a5dd40
to
ec08728
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes the way 'cd' command is used, so it takes into account that each step is run in a separate shell instance.