Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Fix Check ports syscfg update workflow #1716

Closed
wants to merge 1 commit into from

Conversation

wpiet
Copy link
Contributor

@wpiet wpiet commented Mar 1, 2024

Changes the way 'cd' command is used, so it takes into account that each step is run in a separate shell instance.

@@ -58,15 +58,18 @@ jobs:
run: |
cd build
./repos/apache-mynewt-nimble/porting/update_generated_files.sh
cd repos/apache-mynewt-nimble
cd ..
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there's no point in changing working directory at the end of script

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, but that was what @sjanc suggested for this script to be more future-proof. Should I remove these 'cd's at the end of each step?

Changes the way 'cd' command is used, so it takes into account that each step is run in a separate shell instance.
@wpiet wpiet closed this May 23, 2024
@wpiet wpiet deleted the sysfg-check-ci-fix branch May 23, 2024 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants