Some EATT fixes #1728
Merged
Some EATT fixes #1728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
#AutoPTS run mynewt GATT L2CAP |
|
Scheduled PR ##1728 (comment) after 14:16:26. |
andrzej-kaczmarek
approved these changes
Mar 20, 2024
If ble_eatt_conn_pool was empty we would end up in writing NULL address.
It is not used outside of ble_eatt.c
Return error code instead of asserting on low resources.
EATT requires Enhanced COC and number of available channels should be at least that of supported EATT channels.
ble_l2cap_recv_ready consumes om buffer only on success.
If EATT COC connection failed we need to clean up allocated memory.
Some peers reject connection to EATT PSM if encryption is not enabled. Since EATT requires any PDUs to be sent only on encrypted link we can postpone initiating EATT connection until encryption with no real drawbacks.
|
AutoPTS Bot results: Failed testsGATT GATT/CL/GAD/BV-03-C INCONCGATT GATT/CL/GAN/BV-02-C FAIL GATT GATT/CL/GAR/BI-36-C INCONC GATT GATT/CL/GAR/BI-38-C INCONC GATT GATT/CL/GAR/BI-42-C INCONC GATT GATT/CL/GAR/BI-44-C INCONC GATT GATT/CL/GAR/BV-10-C FAIL GATT GATT/SR/GAN/BV-02-C FATAL ERROR GATT GATT/SR/GAW/BI-32-C FAIL L2CAP L2CAP/ECFC/BI-02-C BTP ERROR L2CAP L2CAP/ECFC/BV-43-C FATAL ERROR - ERRATA TSE18351 L2CAP L2CAP/ECFC/BV-44-C FAIL - ERRATA TSE18351 L2CAP L2CAP/TIM/BV-03-C INCONC Successful testsGATT GATT/CL/GAC/BV-01-C PASSGATT GATT/CL/GAD/BV-01-C PASS GATT GATT/CL/GAD/BV-02-C PASS GATT GATT/CL/GAD/BV-04-C PASS GATT GATT/CL/GAD/BV-05-C PASS GATT GATT/CL/GAD/BV-06-C PASS GATT GATT/CL/GAI/BI-01-C PASS GATT GATT/CL/GAI/BV-01-C PASS GATT GATT/CL/GAN/BV-01-C PASS GATT GATT/CL/GAR/BI-01-C PASS GATT GATT/CL/GAR/BI-02-C PASS GATT GATT/CL/GAR/BI-04-C PASS GATT GATT/CL/GAR/BI-05-C PASS GATT GATT/CL/GAR/BI-06-C PASS GATT GATT/CL/GAR/BI-07-C PASS GATT GATT/CL/GAR/BI-10-C PASS GATT GATT/CL/GAR/BI-11-C PASS GATT GATT/CL/GAR/BI-12-C PASS GATT GATT/CL/GAR/BI-13-C PASS GATT GATT/CL/GAR/BI-14-C PASS GATT GATT/CL/GAR/BI-16-C PASS GATT GATT/CL/GAR/BI-17-C PASS GATT GATT/CL/GAR/BI-18-C PASS GATT GATT/CL/GAR/BI-19-C PASS GATT GATT/CL/GAR/BI-21-C PASS GATT GATT/CL/GAR/BI-22-C PASS GATT GATT/CL/GAR/BI-35-C PASS GATT GATT/CL/GAR/BV-01-C PASS GATT GATT/CL/GAR/BV-03-C PASS GATT GATT/CL/GAR/BV-04-C PASS GATT GATT/CL/GAR/BV-05-C PASS GATT GATT/CL/GAR/BV-06-C PASS GATT GATT/CL/GAR/BV-07-C PASS GATT GATT/CL/GAR/BV-08-C PASS GATT GATT/CL/GAS/BV-01-C PASS GATT GATT/CL/GAT/BV-01-C PASS GATT GATT/CL/GAT/BV-02-C PASS GATT GATT/CL/GAT/BV-03-C PASS GATT GATT/CL/GAW/BI-02-C PASS GATT GATT/CL/GAW/BI-03-C PASS GATT GATT/CL/GAW/BI-05-C PASS GATT GATT/CL/GAW/BI-06-C PASS GATT GATT/CL/GAW/BI-07-C PASS GATT GATT/CL/GAW/BI-08-C PASS GATT GATT/CL/GAW/BI-09-C PASS GATT GATT/CL/GAW/BI-12-C PASS GATT GATT/CL/GAW/BI-13-C PASS GATT GATT/CL/GAW/BI-32-C PASS GATT GATT/CL/GAW/BI-33-C PASS GATT GATT/CL/GAW/BI-34-C PASS GATT GATT/CL/GAW/BV-01-C PASS GATT GATT/CL/GAW/BV-03-C PASS GATT GATT/CL/GAW/BV-05-C PASS GATT GATT/CL/GAW/BV-06-C PASS GATT GATT/CL/GAW/BV-08-C PASS GATT GATT/CL/GAW/BV-09-C PASS GATT GATT/SR/GAC/BI-01-C PASS GATT GATT/SR/GAC/BV-01-C PASS GATT GATT/SR/GAD/BV-01-C PASS GATT GATT/SR/GAD/BV-02-C PASS GATT GATT/SR/GAD/BV-03-C PASS GATT GATT/SR/GAD/BV-04-C PASS GATT GATT/SR/GAD/BV-05-C PASS GATT GATT/SR/GAD/BV-06-C PASS GATT GATT/SR/GAI/BV-01-C PASS GATT GATT/SR/GAN/BV-01-C PASS GATT GATT/SR/GAR/BI-01-C PASS GATT GATT/SR/GAR/BI-02-C PASS GATT GATT/SR/GAR/BI-04-C PASS GATT GATT/SR/GAR/BI-05-C PASS GATT GATT/SR/GAR/BI-06-C PASS GATT GATT/SR/GAR/BI-07-C PASS GATT GATT/SR/GAR/BI-08-C PASS GATT GATT/SR/GAR/BI-10-C PASS GATT GATT/SR/GAR/BI-11-C PASS GATT GATT/SR/GAR/BI-12-C PASS GATT GATT/SR/GAR/BI-13-C PASS GATT GATT/SR/GAR/BI-14-C PASS GATT GATT/SR/GAR/BI-16-C PASS GATT GATT/SR/GAR/BI-17-C PASS GATT GATT/SR/GAR/BI-18-C PASS GATT GATT/SR/GAR/BI-19-C PASS GATT GATT/SR/GAR/BI-21-C PASS GATT GATT/SR/GAR/BI-22-C PASS GATT GATT/SR/GAR/BI-36-C PASS GATT GATT/SR/GAR/BI-38-C PASS GATT GATT/SR/GAR/BI-42-C PASS GATT GATT/SR/GAR/BI-44-C PASS GATT GATT/SR/GAR/BI-45-C PASS GATT GATT/SR/GAR/BV-01-C PASS GATT GATT/SR/GAR/BV-03-C PASS GATT GATT/SR/GAR/BV-04-C PASS GATT GATT/SR/GAR/BV-05-C PASS GATT GATT/SR/GAR/BV-06-C PASS GATT GATT/SR/GAR/BV-07-C PASS GATT GATT/SR/GAR/BV-08-C PASS GATT GATT/SR/GAR/BV-09-C PASS GATT GATT/SR/GAR/BV-11-C PASS GATT GATT/SR/GAS/BV-01-C PASS GATT GATT/SR/GAT/BV-01-C PASS GATT GATT/SR/GAW/BI-02-C PASS GATT GATT/SR/GAW/BI-03-C PASS GATT GATT/SR/GAW/BI-05-C PASS GATT GATT/SR/GAW/BI-06-C PASS GATT GATT/SR/GAW/BI-07-C PASS GATT GATT/SR/GAW/BI-08-C PASS GATT GATT/SR/GAW/BI-09-C PASS GATT GATT/SR/GAW/BI-12-C PASS GATT GATT/SR/GAW/BI-13-C PASS GATT GATT/SR/GAW/BI-33-C PASS GATT GATT/SR/GAW/BV-01-C PASS GATT GATT/SR/GAW/BV-03-C PASS GATT GATT/SR/GAW/BV-05-C PASS GATT GATT/SR/GAW/BV-06-C PASS (2) GATT GATT/SR/GAW/BV-07-C PASS GATT GATT/SR/GAW/BV-08-C PASS GATT GATT/SR/GAW/BV-09-C PASS GATT GATT/SR/GAW/BV-10-C PASS GATT GATT/SR/GAW/BV-11-C PASS GATT GATT/SR/GPM/BV-05-C PASS GATT GATT/SR/UNS/BI-01-C PASS GATT GATT/SR/UNS/BI-02-C PASS L2CAP L2CAP/COS/CFC/BV-01-C PASS L2CAP L2CAP/COS/CFC/BV-02-C PASS L2CAP L2CAP/COS/CFC/BV-03-C PASS L2CAP L2CAP/COS/CFC/BV-04-C PASS L2CAP L2CAP/COS/CFC/BV-05-C PASS L2CAP L2CAP/COS/ECFC/BV-01-C PASS L2CAP L2CAP/COS/ECFC/BV-02-C PASS L2CAP L2CAP/COS/ECFC/BV-03-C PASS L2CAP L2CAP/COS/ECFC/BV-04-C PASS L2CAP L2CAP/ECFC/BI-01-C PASS L2CAP L2CAP/ECFC/BI-03-C PASS L2CAP L2CAP/ECFC/BI-04-C PASS L2CAP L2CAP/ECFC/BI-05-C PASS L2CAP L2CAP/ECFC/BI-06-C PASS L2CAP L2CAP/ECFC/BI-07-C PASS L2CAP L2CAP/ECFC/BI-08-C PASS L2CAP L2CAP/ECFC/BV-01-C PASS L2CAP L2CAP/ECFC/BV-02-C PASS L2CAP L2CAP/ECFC/BV-03-C PASS L2CAP L2CAP/ECFC/BV-04-C PASS L2CAP L2CAP/ECFC/BV-06-C PASS L2CAP L2CAP/ECFC/BV-07-C PASS L2CAP L2CAP/ECFC/BV-08-C PASS L2CAP L2CAP/ECFC/BV-09-C PASS L2CAP L2CAP/ECFC/BV-10-C PASS L2CAP L2CAP/ECFC/BV-11-C PASS L2CAP L2CAP/ECFC/BV-12-C PASS L2CAP L2CAP/ECFC/BV-13-C PASS L2CAP L2CAP/ECFC/BV-14-C PASS L2CAP L2CAP/ECFC/BV-15-C PASS L2CAP L2CAP/ECFC/BV-16-C PASS L2CAP L2CAP/ECFC/BV-17-C PASS L2CAP L2CAP/ECFC/BV-18-C PASS L2CAP L2CAP/ECFC/BV-19-C PASS L2CAP L2CAP/ECFC/BV-20-C PASS L2CAP L2CAP/ECFC/BV-21-C PASS L2CAP L2CAP/ECFC/BV-22-C PASS L2CAP L2CAP/ECFC/BV-23-C PASS L2CAP L2CAP/ECFC/BV-24-C PASS L2CAP L2CAP/ECFC/BV-25-C PASS L2CAP L2CAP/ECFC/BV-26-C PASS L2CAP L2CAP/ECFC/BV-27-C PASS L2CAP L2CAP/ECFC/BV-28-C PASS L2CAP L2CAP/ECFC/BV-29-C PASS L2CAP L2CAP/ECFC/BV-30-C PASS L2CAP L2CAP/ECFC/BV-31-C PASS L2CAP L2CAP/ECFC/BV-32-C PASS L2CAP L2CAP/ECFC/BV-33-C PASS L2CAP L2CAP/ECFC/BV-34-C PASS L2CAP L2CAP/ECFC/BV-35-C PASS L2CAP L2CAP/ECFC/BV-38-C PASS L2CAP L2CAP/ECFC/BV-39-C PASS L2CAP L2CAP/ECFC/BV-41-C PASS L2CAP L2CAP/LE/CFC/BI-01-C PASS L2CAP L2CAP/LE/CFC/BI-02-C PASS L2CAP L2CAP/LE/CFC/BV-01-C PASS L2CAP L2CAP/LE/CFC/BV-02-C PASS L2CAP L2CAP/LE/CFC/BV-03-C PASS L2CAP L2CAP/LE/CFC/BV-04-C PASS L2CAP L2CAP/LE/CFC/BV-05-C PASS L2CAP L2CAP/LE/CFC/BV-06-C PASS L2CAP L2CAP/LE/CFC/BV-07-C PASS L2CAP L2CAP/LE/CFC/BV-08-C PASS L2CAP L2CAP/LE/CFC/BV-09-C PASS L2CAP L2CAP/LE/CFC/BV-10-C PASS L2CAP L2CAP/LE/CFC/BV-11-C PASS L2CAP L2CAP/LE/CFC/BV-12-C PASS L2CAP L2CAP/LE/CFC/BV-13-C PASS L2CAP L2CAP/LE/CFC/BV-14-C PASS L2CAP L2CAP/LE/CFC/BV-15-C PASS L2CAP L2CAP/LE/CFC/BV-16-C PASS L2CAP L2CAP/LE/CFC/BV-18-C PASS L2CAP L2CAP/LE/CFC/BV-19-C PASS L2CAP L2CAP/LE/CFC/BV-20-C PASS L2CAP L2CAP/LE/CFC/BV-21-C PASS L2CAP L2CAP/LE/CFC/BV-22-C PASS L2CAP L2CAP/LE/CFC/BV-23-C PASS L2CAP L2CAP/LE/CFC/BV-24-C PASS L2CAP L2CAP/LE/CFC/BV-25-C PASS L2CAP L2CAP/LE/CFC/BV-26-C PASS L2CAP L2CAP/LE/CFC/BV-27-C PASS L2CAP L2CAP/LE/CFC/BV-28-C PASS L2CAP L2CAP/LE/CFC/BV-29-C PASS L2CAP L2CAP/LE/CFC/BV-30-C PASS L2CAP L2CAP/LE/CFC/BV-31-C PASS L2CAP L2CAP/LE/CID/BI-01-C PASS L2CAP L2CAP/LE/CPU/BI-01-C PASS L2CAP L2CAP/LE/CPU/BI-02-C PASS L2CAP L2CAP/LE/CPU/BV-01-C PASS L2CAP L2CAP/LE/CPU/BV-02-C PASS L2CAP L2CAP/LE/REJ/BI-01-C PASS L2CAP L2CAP/LE/REJ/BI-02-C PASS |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.