nimble/ll: Advertising fixes #1730
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrzej-kaczmarek
force-pushed
the
ll-adv-resched
branch
3 times, most recently
from
e23b085
to
9d02fe5
Compare
andrzej-kaczmarek
changed the title
andrzej-kaczmarek
force-pushed
the
ll-adv-resched
branch
from
9d02fe5
to
d41dc47
Compare
Currently we simply drop adv event if it was preempted, but instead we can try to reschedule it as longs as new start time does not exceed adv_delay limit. Note that we only reschedule if no PDU was sent in that event, otherwise we could not guarantee that aux is properly scheduled relative to exts.
We only need current interval, no need to store min and max (and min was never used anyway).
We need to move periodic advertising event start time by full interval (not only ticks) as otherwise any calculation of start time in the future event will not be accurate.
andrzej-kaczmarek
force-pushed
the
ll-adv-resched
branch
from
d41dc47
to
eb5f483
Compare
sjanc
approved these changes
Mar 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
some advertising fixes: