Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nimble/host: Fix legacy advertising API with EXT_ADV enabled #1775

Merged
merged 1 commit into from
May 17, 2024

Conversation

sjanc
Copy link
Contributor

@sjanc sjanc commented May 8, 2024

Configured advertisign instance is required in order to set advertising data when extended advertising HCI is used. Since when legacy PDU are in use we can set both AD and SCAN_RSP we can easily pre-configure selected instance just for this purpose and re-configure it before starting advertising without affecting set AD/SCAN_RSP.

Configured advertisign instance is required in order to set advertising
data when extended advertising HCI is used. Since when legacy PDU are
in use we can set both AD and SCAN_RSP we can easily pre-configure
selected instance just for this purpose and re-configure it before
starting advertising without affecting set AD/SCAN_RSP.
@sjanc
Copy link
Contributor Author

sjanc commented May 8, 2024

#AutoPTS run mynewt MESH/NODE/CFG/AKL/BV-02-C

@codecoup-tester
Copy link

Scheduled PR ##1775 (comment) after 13:19:23.

@codecoup-tester
Copy link

AutoPTS Bot failed:
Build and flash step failed

@codecoup-tester
Copy link

Scheduled PR ##1775 (comment) after 15:54:59.

@codecoup-tester
Copy link

AutoPTS Bot results:

Failed testsMESH MESH/NODE/CFG/AKL/BV-02-C FAIL

@sjanc
Copy link
Contributor Author

sjanc commented May 8, 2024

#AutoPTS run mynewt MESH/NODE/BCN/SNB/BV-01-C

@codecoup-tester
Copy link

Scheduled PR ##1775 (comment) after 16:17:45.

@codecoup-tester
Copy link

AutoPTS Bot results:

Failed testsMESH MESH/NODE/BCN/SNB/BV-01-C FAIL

Copy link
Contributor

@rymanluk rymanluk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sjanc sjanc merged commit 04fea98 into apache:master May 17, 2024
18 checks passed
@sjanc sjanc deleted the legacy_adv_fix2 branch May 17, 2024 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants