Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apps/auracast_usb: broadcast improvements #1776

Merged
merged 4 commits into from
Jul 1, 2024

Conversation

KKopyscinski
Copy link
Contributor

this commit:

  • adds fix for crash on to much/corrupted data on USD
  • adds support for all LC3 samplerates (besides 44.1kHz - unsupported)
  • fixes broadcast with HCI feedback disabled
  • by default resampler is disabled - only works for low samplerates, or low quality

Copy link
Contributor

@rymanluk rymanluk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like it should be 5 separate commits

@KKopyscinski
Copy link
Contributor Author

Looks like it should be 5 separate commits

will split

If USB pushes more data then it should, handle it more gracefully.
Only 44.1 is unsupported, rest should be configurable.
When HCI feedback is disabled, we shall use LC3 internal resampler.
Adjusted samplerate on LC3 input to accomodate this.
Resampler only works fast enough for low output samplerates. Set higher
quality as default, and disable resampler - use one from LC3.
Copy link
Contributor

@rymanluk rymanluk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rymanluk rymanluk merged commit debd473 into apache:master Jul 1, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants