BASS & GATT fixes. #1779
Merged
BASS & GATT fixes. #1779
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sjanc @KKopyscinski FYI |
sjanc
requested changes
May 14, 2024
This commit changes BASS audio scan control point and BASS broadcast receive state characteristics properties. Previous properties were not correct with specification.
szymon-czapracki
force-pushed
the
bass_fixes
branch
from
776a14a
to
966fcad
Compare
Change keyword and description from PACS to BASS.
sjanc
reviewed
May 15, 2024
| #define BLE_GATT_CHR_F_AUTH_SIGN_WRITE 0x0040 | ||
|
|
||
| /** GATT Characteristic Flag: Reliable Writes. */ |
There was a problem hiding this comment.
reliable writes are (extended) property, not permission
This commit changes GATT flags descriptions, making them more readable regarding permissions and properties.
szymon-czapracki
force-pushed
the
bass_fixes
branch
2 times, most recently
from
f8af0ed
to
3341671
Compare
This commit modifies GATT functions description to get them up to speed with current doxygen rules.
|
BASS related changes LGTM |
sjanc
approved these changes
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed characteristic properties.
Changed naming.