apps/auracast: Make the code compile on native target #1783
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjanc
requested changes
May 17, 2024
MariuszSkamra
force-pushed
the
auracast_on_native
branch
from
3d4fa24
to
7817bab
Compare
|
there's already hal_gpio for native so you can just add missing APIs there |
MariuszSkamra
force-pushed
the
auracast_on_native
branch
from
7817bab
to
2942151
Compare
|
As discussed with @andrzej-kaczmarek offline, the button pin number is configurable via syscfg. If valid (> 0), the broadcaster functionality is enabled; disabled otherwise. |
sjanc
reviewed
Jun 20, 2024
apps/auracast/src/main.c
Outdated
| @@ -60,12 +63,12 @@ static uint16_t bis_handles[MYNEWT_VAL(BROADCASTER_CHAN_NUM)]; | |||
| static struct os_callout audio_broadcast_callout; | |||
|
|
|||
| static int audio_data_offset; | |||
| static uint8_t auracast_adv_instance; | |||
|
|
|||
| #if STOP_ON_BUTTON_PRESS | |||
There was a problem hiding this comment.
this can be
#if MYNEWT_VAL(BROADCASTER_STOP_BUTTON) >= 0
so no need for extra wrap macro (this is how we typically do this in codebase)
There was a problem hiding this comment.
@MariuszSkamra could you help with this?
MariuszSkamra
force-pushed
the
auracast_on_native
branch
from
2942151
to
49cdbfb
Compare
sjanc
reviewed
Jul 22, 2024
apps/auracast/syscfg.yml
Outdated
| description: > | ||
| Button number for Broadcast Stop action. | ||
| Negative value if disabled. | ||
| value: 3 |
There was a problem hiding this comment.
shouldn't this be BUTTON_3 ? otherwise looks ok to me
This fixes auracast native build by disabling GPIO button functionality.
MariuszSkamra
force-pushed
the
auracast_on_native
branch
from
49cdbfb
to
7ac0c7c
Compare
|
@sjanc PING |
sjanc
approved these changes
Sep 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes auracast native build by disabling GPIO button functionality.