Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nimble/transport: Fix undeclared function 'min' warning #1785

Merged

Conversation

guy-m
Copy link
Contributor

@guy-m guy-m commented May 20, 2024

Fix build warning generated with llvm based compilers on a call to undeclared function 'min'.

Fix build warning generated with llvm based compilers on a call to undeclared function 'min'.
Copy link
Contributor

@sjanc sjanc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andrzej-kaczmarek I guess we should think about some common ble_utils.h or similar in long run...

@guy-m
Copy link
Contributor Author

guy-m commented May 20, 2024

@sjanc Yes. I agree. That way we can avoid adding these definitions (and others) in multiple c files.

@andrzej-kaczmarek andrzej-kaczmarek merged commit 89d6fd6 into apache:master May 20, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants