Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: auto-update ports syscfg #1786

Merged
merged 2 commits into from
Jun 20, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions .github/LICENSE_TEMPLATE
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
/*
* Licensed to the Apache Software Foundation (ASF) under one
* or more contributor license agreements. See the NOTICE file
* distributed with this work for additional information
* regarding copyright ownership. The ASF licenses this file
* to you under the Apache License, Version 2.0 (the
* "License"); you may not use this file except in compliance
* with the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing,
* software distributed under the License is distributed on an
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
* KIND, either express or implied. See the License for the
* specific language governing permissions and limitations
* under the License.
*/
47 changes: 39 additions & 8 deletions .github/workflows/ports_syscfg_check.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,12 +19,20 @@

name: Check ports syscfg update

on: [pull_request]
on:
push:
branches:
- 'master'
paths:
- '*/syscfg.h'

jobs:
targets:
name: Check ports syscfg update
runs-on: ubuntu-latest
permissions:
contents: write
pull-requests: write
steps:
- uses: actions/checkout@v3
- uses: actions/setup-go@v3
Expand Down Expand Up @@ -52,23 +60,46 @@ jobs:
newt upgrade --shallow=1
rm -rf repos/apache-mynewt-nimble
git clone .. repos/apache-mynewt-nimble
cd ..
- name: Build ports tests targets
shell: bash
run: |
cd build
./repos/apache-mynewt-nimble/porting/update_generated_files.sh
cd repos/apache-mynewt-nimble
- name: Check ports syscfg (debug)
shell: bash
if: runner.debug == '1'
run: |
cd build/repos/apache-mynewt-nimble
git diff
- name: Check ports syscfg
shell: bash
run: |
git diff --quiet || (\
echo -e "\033[0;31mChanges in system configration files detected.";
echo -e "\033[0;31mRun ./repos/apache-mynewt-nimble/porting/update_generated_files.sh" \
"to update NimBLE ports configurations.";
exit 1)
cd build/repos/apache-mynewt-nimble
if ! git diff --quiet; then
echo -e "\033[0;31mChanges in system configuration files detected:"
git diff --name-only
cp porting/examples/linux/include/syscfg/syscfg.h ../../../porting/examples/linux/include/syscfg/syscfg.h
cp porting/examples/linux_blemesh/include/syscfg/syscfg.h ../../../porting/examples/linux_blemesh/include/syscfg/syscfg.h
cp porting/examples/nuttx/include/syscfg/syscfg.h ../../../porting/examples/nuttx/include/syscfg/syscfg.h
cp porting/nimble/include/syscfg/syscfg.h ../../../porting/nimble/include/syscfg/syscfg.h
cp porting/npl/riot/include/syscfg/syscfg.h ../../../porting/npl/riot/include/syscfg/syscfg.h
else
echo "No changes detected in system configuration files."
fi
cd ../../..
rm -rf build
- name: Create Pull Request
uses: peter-evans/create-pull-request@v6
with:
token: ${{ secrets.GITHUB_TOKEN }}
commit-message: |
porting: Update ports syscfg
branch: update-ports-syscfg
title: "Update ports syscfg"
body: |
Update NimBLE ports configurations:
- Removes all /* */ comments from `syscfg.h` files.
- Adds the license header to each `syscfg.h` file.
- Auto-generated by [create-pull-request][1]

[1]: https://github.com/peter-evans/create-pull-request
7 changes: 4 additions & 3 deletions porting/update_generated_files.sh
Original file line number Diff line number Diff line change
Expand Up @@ -37,9 +37,10 @@ for target in "${!targets[@]}"; do
rm -rf "bin/@apache-mynewt-nimble/porting/targets/${target}/generated/include/logcfg"
rm -rf "bin/@apache-mynewt-nimble/porting/targets/${target}/generated/include/sysflash"
cp "bin/@apache-mynewt-nimble/porting/targets/${target}/generated/include" "${targets[$target]}" -r
# Remove repo version and hash MYNEWT_VALS as it doesn't make much sense to commit them and they
# defeat the purpose of this script.
# Remove all comments and hash MYNEWT_VALS as it doesn't make much sense to commit them and they
# defeat the purpose of this script. Prepend the license header.
find "${targets[$target]}/include" -type f -name 'syscfg.h' -exec sed -i '/MYNEWT_VAL_REPO_*/,/#endif/d' {} \;
find "${targets[$target]}/include" -type f -name 'syscfg.h' -exec sed -i '/\/\*\*\* Repository/,/\*\//d' {} \;
find "${targets[$target]}/include" -type f -name 'syscfg.h' -exec sed -i -E ':a;N;$!ba;s:/\*([^*]|(\*+([^*/])))*\*+/::g' {} \;
find "${targets[$target]}/include" -type f -name 'syscfg.h' -exec sed -i '$!N;/^\n$/{$q;D;};P;D;' {} \;
find "${targets[$target]}/include" -type f -name 'syscfg.h' -exec sh -c 'cat "$0" "$1" > "$1.tmp" && mv "$1.tmp" "$1"' "../.github/LICENSE_TEMPLATE" {} \;
done
Loading