nimble/host: Fix invalid memset in ble_gattc_read_mult_cb_var #1791
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
piotrnarajowski
commented
Jun 3, 2024
piotrnarajowski
commented
- Add early exit in read_var_cb for readabilty
- Apply correct value when using memset to fill attr array in ble_gattc_read_mult_cb_var. Fixes GATT/CL/GAR/BI-13-C, GATT/CL/GAR/BI-36-C, GATT/CL/GAR/BI-38-C, GATT/CL/GAR/BI-42-C, GATT/CL/GAR/BI-44-C, GATT/CL/GAR/BV-05-C
nimble/host/src/ble_gattc.c
Outdated
| @@ -3345,7 +3345,7 @@ ble_gattc_read_mult_cb_var(struct ble_gattc_proc *proc, int status, | |||
| return 0; | |||
| } | |||
|
|
|||
| memset(attr, 0, sizeof(*attr)); | |||
| memset(attr, 0, sizeof(*attr) * proc->read_mult.num_handles); | |||
There was a problem hiding this comment.
Instructions unclear. Now it's properly fixed
This commit applies correct value when using memset to fill attr array. Fixes GATT/CL/GAR/BI-13-C, GATT/CL/GAR/BI-36-C, GATT/CL/GAR/BI-38-C, GATT/CL/GAR/BI-42-C, GATT/CL/GAR/BI-44-C, GATT/CL/GAR/BV-05-C
This commit applies early exit if status != 0.
sjanc
approved these changes
Jun 4, 2024
andrzej-kaczmarek
approved these changes
Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.