nimble/host: Modify Advertising Tx power levels #1815
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
this depends on core spec version so should be #ifdef also if you refer to spec, please include reference to exact core spec version and section |
rahult-github
force-pushed
the
bugfix/adjust_tx_power_lvl_boundary
branch
from
6e75282
to
7f59b88
Compare
Thanks for this, have updated the PR to reflect different versions and updated the description too |
Spec ver 5.4 , Vol 4, Part E, section 7.8.6 mentions the range value for Tx power level. Different BLE spec version have modified the range values that Tx Power level can have. Update the min / max macros to reflect the same
rahult-github
force-pushed
the
bugfix/adjust_tx_power_lvl_boundary
branch
from
7f59b88
to
9cb35ee
Compare
sjanc
approved these changes
Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For LE Read Advertising Physical Channel Tx Power command , different version of BLE specification have updated the return values for Tx Power level.
Currently (spec 5.2 onwards) the supported values are from (-127) to (20).
Latest values as per Spec ver 5.4 , Vol 4, Part E, section 7.8.6 has range specified.
Update the min / max macros to reflect the same