Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nimble/ll: Add workaround (hack) for empty BIS pretransmissions #1828

Closed
wants to merge 1 commit into from
Closed

nimble/ll: Add workaround (hack) for empty BIS pretransmissions #1828

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions nimble/controller/src/ble_ll_iso_big.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -704,6 +704,18 @@ ble_ll_iso_big_subevent_pdu_cb(uint8_t *dptr, void *arg, uint8_t *hdr_byte)

#if 1
pdu_len = ble_ll_isoal_mux_unframed_get(&bis->mux, idx, &llid, dptr);

/* FIXME
* This is a very ugly workaround for missing pretransmission data.
* We can't (for now) simply skip single subevent without affecting timing
* of other subevents so in case we have an empty BIS PDU to be sent for
* pretransmission, we'll send it as invalid packet so receiver doesn't
* receive it. It's a temporary solution until we find a better way to
* schedule BIS PDUs.
*/
if ((pdu_len == 0) && (bis->tx.g >= big->irc)) {
ble_phy_setchan(0, 0, 0);
}
#else
llid = 0;
pdu_len = big->max_pdu;
Expand Down
Loading