nimble/audio/bass: Add data length check in BASS remote scan #1834
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rymanluk
reviewed
Aug 19, 2024
| @@ -251,6 +251,10 @@ ble_svc_audio_bass_receive_state_free(struct ble_svc_audio_bass_rcv_state_entry | |||
| static int | |||
| ble_svc_audio_bass_remote_scan_stopped(uint8_t *data, uint16_t data_len, uint16_t conn_handle) | |||
| { | |||
| if (data_len > 1) { | |||
There was a problem hiding this comment.
indentation .
and the error could seems to be BLE_ATT_ERR_WRITE_REQ_REJECTED
rymanluk
reviewed
Aug 19, 2024
| @@ -264,6 +268,10 @@ ble_svc_audio_bass_remote_scan_stopped(uint8_t *data, uint16_t data_len, uint16_ | |||
| static int | |||
| ble_svc_audio_bass_remote_scan_started(uint8_t *data, uint16_t data_len, uint16_t conn_handle) | |||
| { | |||
| if (data_len > 1) { | |||
szymon-czapracki
force-pushed
the
bass_scan_work
branch
from
898f0ad
to
cc96530
Compare
This commit adds data length checks to remote scan operations. Now any data coming with remote scan start/stop will result in instant ATT error.
szymon-czapracki
force-pushed
the
bass_scan_work
branch
from
cc96530
to
4268cea
Compare
rymanluk
approved these changes
Aug 26, 2024
sjanc
approved these changes
Sep 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add data length checks to remote scan operations. Now any data coming with remote scan start/stop will result in instant ATT error.