nimble/transport: Fix build with RX task #1844
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrzej-kaczmarek
force-pushed
the
transport-rx-task-fix
branch
from
96bfa6f
to
4394e2d
Compare
Remove separate syscfg to enable RX task from nrf5340 transport package. RX task is now enabled if RX task stack size is set to a valid value. RX task priority should not be set to default value to avoid conflicts with other task priorities if RX task is not used (this is always verified by newt). Since empty value is not a valid priority we should better only define that setting if RX task is enabled.
andrzej-kaczmarek
force-pushed
the
transport-rx-task-fix
branch
from
4394e2d
to
0eefb7d
Compare
sjanc
approved these changes
Aug 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove separate syscfg to enable RX task from nrf5340 transport package. RX task is now enabled if RX task stack size is set to a valid value.
RX task priority should not be set to default value to avoid conflicts with other task priorities if RX task is not used (this is always verified by newt). Since empty value is not a valid priority we should better only define that setting if RX task is enabled.