Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code style changes #1847

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

vandy
Copy link

@vandy vandy commented Aug 11, 2024

This PR is linked to #1846. Code style changes made during code investigation on the offset.

Copy link
Contributor

@andrzej-kaczmarek andrzej-kaczmarek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

those are not code style changes, you just reformat code that is perfectly fine, e.g. using rc as intermediate value instead of just returning value from function call directly is our preferred way in code.

@vandy
Copy link
Author

vandy commented Aug 12, 2024

"... just reformat code that is perfectly fine" - is what I thought code style changes are. I've reverted some changes. So, please, consider what to do with this PR. Would you accept these changes or not. If not, the PR could be close I suppose.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants