Skip to content

Commit

Permalink
ORC-1514: Remove zookeeper runtime dependency
Browse files Browse the repository at this point in the history
### What changes were proposed in this pull request?

This PR aims to remove Apache Zookeeper Runtime dependency for Apache ORC 2.0.0.

### Why are the changes needed?

Apache ORC 1.4.0 added Zookeeper depdency to the pom file to reduce the uber file size because Zookeeper is used by Hadoop Common module at that time.
- #96

After ORC-1430, Apache ORC 2.0.0 uses Hadoop shaded clients which shaded Zookeeper runtime dependency. We can remove Zookeeper dependency.

- #1509
- #1554

### How was this patch tested?

Pass the CIs.

This closes #1572 .

Closes #1630 from dongjoon-hyun/ORC-1514.

Authored-by: Dongjoon Hyun <dongjoon@apache.org>
Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
  • Loading branch information
dongjoon-hyun committed Oct 1, 2023
1 parent 7e639b9 commit 5f1658e
Showing 1 changed file with 0 additions and 21 deletions.
21 changes: 0 additions & 21 deletions java/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,6 @@
<storage-api.version>2.8.1</storage-api.version>
<surefire.version>3.0.0-M5</surefire.version>
<test.tmp.dir>${project.build.directory}/testing-tmp</test.tmp.dir>
<zookeeper.version>3.8.1</zookeeper.version>
</properties>

<dependencyManagement>
Expand Down Expand Up @@ -175,26 +174,6 @@
</exclusion>
</exclusions>
</dependency>
<dependency>
<groupId>org.apache.zookeeper</groupId>
<artifactId>zookeeper</artifactId>
<version>${zookeeper.version}</version>
<scope>runtime</scope>
<exclusions>
<exclusion>
<groupId>io.netty</groupId>
<artifactId>netty-handler</artifactId>
</exclusion>
<exclusion>
<groupId>io.netty</groupId>
<artifactId>netty-transport-native-epoll</artifactId>
</exclusion>
<exclusion>
<groupId>ch.qos.logback</groupId>
<artifactId>logback-classic</artifactId>
</exclusion>
</exclusions>
</dependency>
<dependency>
<groupId>org.jetbrains</groupId>
<artifactId>annotations</artifactId>
Expand Down

0 comments on commit 5f1658e

Please sign in to comment.