Skip to content

Commit

Permalink
ORC-1819: [FOLLOWUP] Fix baseurl parameter and more links
Browse files Browse the repository at this point in the history
### What changes were proposed in this pull request?

This is a follow-up to fix `baseurl` parameter and more links.
- #2095

### Why are the changes needed?

`baseurl` option is defined like the following.
- https://jekyllrb.com/docs/configuration/options/
> Base URL: Serve the website from the given base URL (the path between web-server or domain root and your landing page).

This only updates https://apache.github.io/orc/ while keeping https://orc.apache.org unchanged.

### How was this patch tested?

Manual review.

### Was this patch authored or co-authored using generative AI tooling?

No.

Closes #2099 from dongjoon-hyun/links.

Authored-by: Dongjoon Hyun <dongjoon@apache.org>
Signed-off-by: William Hyun <william@apache.org>
  • Loading branch information
dongjoon-hyun authored and williamhyun committed Jan 4, 2025
1 parent 86b6926 commit c020fe6
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/pages.yml
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ jobs:
gem install bundler -n /usr/local/bin
bundle install --retry=100
git clone https://github.com/apache/orc.git -b asf-site target
bundle exec jekyll build -b https://apache.github.io/orc
bundle exec jekyll build -b /orc
- name: Setup Pages
uses: actions/configure-pages@v5
- name: Upload artifact
Expand Down
2 changes: 1 addition & 1 deletion site/_includes/docs_ul.html
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@

{% for p in site.docs %}
{% if p.url == item_url %}
<li class="{{ c }}"><a href="{{ p.url }}">{{ p.title }}</a></li>
<li class="{{ c }}"><a href="{{ site.baseurl }}{{ p.url }}">{{ p.title }}</a></li>
{% break %}
{% endif %}
{% endfor %}
Expand Down
2 changes: 1 addition & 1 deletion site/_includes/header.html
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
<div class="grid">
<div class="unit one-quarter center-on-mobiles">
<h1>
<a href="/">
<a href="{{ site.baseurl }}/">
<span class="sr-only">Apache ORC</span>
<img src="{{ site.baseurl }}/img/logo.png" width="249" height="101" alt="ORC Logo">
</a>
Expand Down
4 changes: 2 additions & 2 deletions site/_includes/news_contents.html
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ <h4>Recent Releases</h4>
<ul>
{% for post in site.categories.release limit:5 %}
<li class="{% if page.title == post.title %}current{% endif %}">
<a href="{{ post.url }}">Version {{ post.version }}</a>
<a href="{{ site.baseurl }}{{ post.url }}">Version {{ post.version }}</a>
</li>
{% endfor %}
</ul>
Expand All @@ -21,7 +21,7 @@ <h4>Other News</h4>
{% for post in site.posts %}
{% unless post.categories contains 'release' %}
<li class="{% if page.title == post.title %}current{% endif %}">
<a href="{{ post.url }}">{{ post.title }}</a>
<a href="{{ site.baseurl }}{{ post.url }}">{{ post.title }}</a>
</li>
{% endunless %}
{% endfor %}
Expand Down

0 comments on commit c020fe6

Please sign in to comment.