ORC-1387: [C++] Support schema evolution from decimal to numeric/decimal #1629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wgtmac
reviewed
Oct 8, 2023
c++/test/TestInt128.cc
Outdated
| @@ -1201,4 +1201,20 @@ namespace orc { | |||
| << pair.second.toString(); | |||
| } | |||
|
|
|||
| TEST(Int128, testConverToDouble) { | |||
There was a problem hiding this comment.
Suggested change
| TEST(Int128, testConverToDouble) { | |
| TEST(Int128, testConvertToDouble) { |
c++/src/ConvertColumnReader.cc
Outdated
| const FileTypeBatch& srcBatch) { | ||
| using FileType = decltype(srcBatch.values[idx]); | ||
| Int128 result = scaleDownInt128ByPowerOfTen(srcBatch.values[idx], scale); | ||
| int64_t longValue = result.toLong(); |
There was a problem hiding this comment.
This would be better to move to below line 508.
c++/src/ConvertColumnReader.cc
Outdated
Comment on lines
515
to
517
| double doubleValue = 0; | ||
| Int128 i128 = srcBatch.values[idx]; | ||
| doubleValue = i128.toDouble(); |
There was a problem hiding this comment.
Suggested change
| double doubleValue = 0; | |
| Int128 i128 = srcBatch.values[idx]; | |
| doubleValue = i128.toDouble(); | |
| double doubleValue = srcBatch.values[idx].toDouble(); |
wgtmac
approved these changes
Oct 10, 2023
cxzl25
pushed a commit
to cxzl25/orc
that referenced
this pull request
Jan 11, 2024
### What changes were proposed in this pull request?
Support schema evolution from decimal to {boolean, byte, short, int, long, float, double, decimal}
### Why are the changes needed?
to support schema evolution
### How was this patch tested?
UT passed
Closes apache#1629 from ffacs/ORC-1387.
Authored-by: ffacs <ffacs520@gmail.com>
Signed-off-by: Gang Wu <ustcwg@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Support schema evolution from decimal to {boolean, byte, short, int, long, float, double, decimal}
Why are the changes needed?
to support schema evolution
How was this patch tested?
UT passed