ORC-1480: [C++] Fix build break w/ BUILD_CPP_ENABLE_METRICS=ON #1646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
|
Thank you @ffacs and @dongjoon-hyun ! |
wgtmac
added a commit
that referenced
this pull request
Nov 3, 2023
### What changes were proposed in this pull request? Pass IOCount to SCOPED_STOPWATCH when counting I/Os. ### Why are the changes needed? SCOPED_STOPWATCH macro was not correctly called when counting I/Os. This breaks build when BUILD_CPP_ENABLE_METRICS is set to ON and fails the unit test as well. ### How was this patch tested? Failed test cases are fixed and all cases pass. Closes #1646 from wgtmac/ORC-1480. Authored-by: Gang Wu <ustcwg@gmail.com> Signed-off-by: Gang Wu <ustcwg@gmail.com> (cherry picked from commit 7c83925) Signed-off-by: Gang Wu <ustcwg@gmail.com>
|
I have also backported it into branch-1.9 |
cxzl25
pushed a commit
to cxzl25/orc
that referenced
this pull request
Jan 11, 2024
### What changes were proposed in this pull request? Pass IOCount to SCOPED_STOPWATCH when counting I/Os. ### Why are the changes needed? SCOPED_STOPWATCH macro was not correctly called when counting I/Os. This breaks build when BUILD_CPP_ENABLE_METRICS is set to ON and fails the unit test as well. ### How was this patch tested? Failed test cases are fixed and all cases pass. Closes apache#1646 from wgtmac/ORC-1480. Authored-by: Gang Wu <ustcwg@gmail.com> Signed-off-by: Gang Wu <ustcwg@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Pass IOCount to SCOPED_STOPWATCH when counting I/Os.
Why are the changes needed?
SCOPED_STOPWATCH macro was not correctly called when counting I/Os. This breaks build when BUILD_CPP_ENABLE_METRICS is set to ON and fails the unit test as well.
How was this patch tested?
Failed test cases are fixed and all cases pass.