-
Notifications
You must be signed in to change notification settings - Fork 486
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ORC-1545: [JAVA] Use orc-format
1.0.0-SNAPSHOT
#1683
Conversation
cc @williamhyun , @wgtmac , @guiyanakuang, @mystic-lama |
orc-format
1.0.0-SNAPSHOT
Merged to main for Apache ORC 2.0.0 |
Thanks @dongjoon-hyun |
@dongjoon-hyun Do we need the shading section on ORC side? We are creating same files on orc-format build too. I am not too sure, so thought of asking Lines 489 to 512 in 54e28b0
|
To @mystic-lama , yes. I was confused like you. Please see here. Since
|
@dongjoon-hyun Thanks ! That explains it well. I was assuming to be the case, the concrete example helps. |
### What changes were proposed in this pull request? This PR aims to use `orc-format` 1.0.0-SNAPSHOT in `Java` as an interim stage. 1. We need to change C++ separately later. 2. After (1), we can delete `proto/orc_proto.proto`. 3. After releasing `orc-format` 1.0.0, we need to use it instead of SNAPSHOT. ### Why are the changes needed? To verify `orc-format` repository and snapshot. ### How was this patch tested? Pass the CIs. Closes apache#1683 from dongjoon-hyun/ORC-1545. Authored-by: Dongjoon Hyun <dongjoon@apache.org> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
What changes were proposed in this pull request?
This PR aims to use
orc-format
1.0.0-SNAPSHOT inJava
as an interim stage.proto/orc_proto.proto
.orc-format
1.0.0, we need to use it instead of SNAPSHOT.Why are the changes needed?
To verify
orc-format
repository and snapshot.How was this patch tested?
Pass the CIs.