ORC-1563: Fix orc.bloom.filter.fpp default value and orc.compress notes of Spark and Hive config docs
#1709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dongjoon-hyun
approved these changes
Dec 27, 2023
| @@ -12,13 +12,13 @@ with the same options. | |||
|
|
|||
| Key | Default | Notes | |||
| :----------------------- | :---------- | :------------------------ | |||
| orc.compress | ZLIB | high level compression = {NONE, ZLIB, SNAPPY} | |||
| orc.compress | ZLIB | high level compression = {NONE, ZLIB, SNAPPY, LZO, LZ4, ZSTD} | |||
There was a problem hiding this comment.
Could you add the JIRA IDs of these too, @cxzl25 ?
There was a problem hiding this comment.
Like this?
orc.compress | ZLIB | high level compression = {NONE, ZLIB, SNAPPY, LZO, LZ4 (ORC-77), ZSTD (ORC-363)}
There was a problem hiding this comment.
No~ What I meant was the PR description. Let me add that to the PR description and merge this.
There was a problem hiding this comment.
Thanks your help. @dongjoon-hyun
dongjoon-hyun
changed the title
orc.bloom.filter.fpp default value and orc.compress notes of Spark and Hive config docs
dongjoon-hyun
pushed a commit
that referenced
this pull request
Dec 27, 2023
… notes of Spark and Hive config docs
### What changes were proposed in this pull request?
1. Add `orc.compress` enumeration value description
- LZO, LZ4 (ORC-77) since ORC 1.2
- ZSTD (ORC-363) since ORC 1.6
2. Fix `orc.bloom.filter.fpp` default value (ORC-1338) since ORC 1.8.2
### Why are the changes needed?
The document is out of date.
### How was this patch tested?
local check
Closes #1709 from cxzl25/ORC-1563.
Authored-by: sychen <sychen@ctrip.com>
Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
(cherry picked from commit 0184a66)
Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
dongjoon-hyun
pushed a commit
that referenced
this pull request
Dec 27, 2023
… notes of Spark and Hive config docs
### What changes were proposed in this pull request?
1. Add `orc.compress` enumeration value description
- LZO, LZ4 (ORC-77) since ORC 1.2
- ZSTD (ORC-363) since ORC 1.6
2. Fix `orc.bloom.filter.fpp` default value (ORC-1338) since ORC 1.8.2
### Why are the changes needed?
The document is out of date.
### How was this patch tested?
local check
Closes #1709 from cxzl25/ORC-1563.
Authored-by: sychen <sychen@ctrip.com>
Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
(cherry picked from commit 0184a66)
Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
|
Merged to main/1.9/1.8. I also published the fixed doc to the webpage, @cxzl25 . |
cxzl25
added a commit
to cxzl25/orc
that referenced
this pull request
Jan 11, 2024
… notes of Spark and Hive config docs
### What changes were proposed in this pull request?
1. Add `orc.compress` enumeration value description
- LZO, LZ4 (ORC-77) since ORC 1.2
- ZSTD (ORC-363) since ORC 1.6
2. Fix `orc.bloom.filter.fpp` default value (ORC-1338) since ORC 1.8.2
### Why are the changes needed?
The document is out of date.
### How was this patch tested?
local check
Closes apache#1709 from cxzl25/ORC-1563.
Authored-by: sychen <sychen@ctrip.com>
Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
orc.compressenumeration value descriptionorc.bloom.filter.fppdefault value (ORC-1338) since ORC 1.8.2Why are the changes needed?
The document is out of date.
How was this patch tested?
local check