ORC-1604: Deprecate non-utf8 bloom filter for Java writer #1776
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dongjoon-hyun
requested changes
Jan 31, 2024
There was a problem hiding this comment.
Hi, @cxzl25 . I agree with your intention.
However, Apache ORC community need a deprecation process before the removal of any public API. I don't think we can remove the API.
Could you convert this PR into a deprecation PR instead of a removal PR?
This reverts commit d2e021a.
cxzl25
changed the title
cxzl25
changed the title
dongjoon-hyun
pushed a commit
that referenced
this pull request
Feb 3, 2024
### What changes were proposed in this pull request? This PR aims to deprecate non-utf8 bloom filter for writer. 1. deprecate `org.apache.orc.OrcFile.WriterOptions#bloomFilterVersion` 2. deprecate `org.apache.orc.OrcFile.WriterOptions#getBloomFilterVersion 3. deprecate `org.apache.orc.impl.writer.WriterContext#getBloomFilterVersion` ### Why are the changes needed? 1. `orc.bloom.filter.write.version=original` will write two copies of data instead of one, which increases the size of ORC and will also cause Spark2.x to fail to read `BloomFilterUtf8` [comment-17800800](https://issues.apache.org/jira/browse/ORC-297?focusedCommentId=17800800&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17800800) 4. C++ writer does not implement original 5. Plan to remove non-utf8 bloom filter in `orc-format` `ORCv2.md` ### How was this patch tested? GA ### Was this patch authored or co-authored using generative AI tooling? No Closes #1776 from cxzl25/ORC-1604. Authored-by: sychen <sychen@ctrip.com> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org> (cherry picked from commit 6c3c451) Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
|
Thank you for updates. Merged to main/2.0 for Apache ORC 2.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR aims to deprecate non-utf8 bloom filter for writer.
org.apache.orc.OrcFile.WriterOptions#bloomFilterVersionorg.apache.orc.impl.writer.WriterContext#getBloomFilterVersionWhy are the changes needed?
orc.bloom.filter.write.version=originalwill write two copies of data instead of one, which increases the size of ORC and will also cause Spark2.x to fail to readBloomFilterUtf8comment-17800800
orc-formatORCv2.mdHow was this patch tested?
GA
Was this patch authored or co-authored using generative AI tooling?
No