ORC-1613: Zstd decompression supports direct buffer #1789
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -214,6 +214,11 @@ public boolean compress(ByteBuffer in, ByteBuffer out, | |||
|
|
|||
| @Override | |||
| public void decompress(ByteBuffer in, ByteBuffer out) throws IOException { | |||
| if (in.isDirect() && out.isDirect()) { | |||
There was a problem hiding this comment.
Just a question. When is this used in Apache ORC code base?
There was a problem hiding this comment.
If we use zerocopy orc.use.zerocopy=true, we may use the direct buffer, which can fallback to the original way of reading if the codec doesn't implement DirectDecompressionCodec.
orc/java/core/src/java/org/apache/orc/impl/RecordReaderUtils.java
Lines 600 to 607 in 4eff23a
dongjoon-hyun
approved these changes
Feb 7, 2024
dongjoon-hyun
approved these changes
Feb 8, 2024
dongjoon-hyun
pushed a commit
that referenced
this pull request
Feb 8, 2024
### What changes were proposed in this pull request? `ZstdCodec` implements the `DirectDecompressionCodec` interface. ### Why are the changes needed? `zstd-jni` supports direct buffer decompression, which can reduce Buffer copying. ### How was this patch tested? add UT ### Was this patch authored or co-authored using generative AI tooling? No Closes #1789 from cxzl25/ORC-1613. Authored-by: sychen <sychen@ctrip.com> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org> (cherry picked from commit 25beaa2) Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
|
Merged to main/2.0. Thank you, @cxzl25 . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
ZstdCodecimplements theDirectDecompressionCodecinterface.Why are the changes needed?
zstd-jnisupports direct buffer decompression, which can reduce Buffer copying.How was this patch tested?
add UT
Was this patch authored or co-authored using generative AI tooling?
No