ORC-1826: [C++][CI] Add ASAN support to CMake #2097
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
.github/workflows/asan_test.yml
Outdated
| jobs: | ||
| asan-test: | ||
| name: "ASAN with ${{ matrix.compiler }} on Ubuntu" | ||
| runs-on: ubuntu-24.04 |
There was a problem hiding this comment.
Just a question; Is it a requirement?
There was a problem hiding this comment.
You mean the ubuntu version? No, I don't think so.
There was a problem hiding this comment.
Thank you for the answer. Yes, I was wondering if ASAN doesn't work on ubuntu-22.04.
If this is working on ubuntu-22.04, we may want to use ubuntu-latest instead of specific versions.
There was a problem hiding this comment.
BTW, I'm fine for the AS-IS PR too.
dongjoon-hyun
approved these changes
Jan 2, 2025
|
Happy New Year, @wgtmac . Shall we convert this to a normal PR in order to deliver this as a part of Apache ORC 2.1.0? |
wgtmac
changed the title
|
Thanks for your suggestion! Now it is ready for review. Happy new year :) @dongjoon-hyun |
|
Thank you, @wgtmac . Merged to main for Apache ORC 2.1. cc @williamhyun |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Add a CMake option to enable ASan in the C++ build and enable it in the CI.
Why are the changes needed?
We are able to detect potential memory issues with the help of address sanitizer.
How was this patch tested?
Pass all CIs (including the new ASan CIs)
Was this patch authored or co-authored using generative AI tooling?
No.