HDDS-11649. Recon ListKeys API: Simplify filter predicates #7395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adoroszlai
reviewed
Nov 6, 2024
hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/api/OMDBInsightEndpoint.java
Outdated
Show resolved
Hide resolved
…/api/OMDBInsightEndpoint.java Co-authored-by: Doroszlai, Attila <6454655+adoroszlai@users.noreply.github.com>
adoroszlai
approved these changes
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
In the Recon ListKeys API, a series of predicate lambdas are created to filter the returned keys. The filters create 3 new lambdas for each key to check and this api could iterate a lot of keys in parallel.
Benchmarking the original code against simple IF statements shows the IF statements to be about 3x faster. However the creation of all the lambda object resulted in about 4500MB/s of short lived objects.
This PR simplifies the code to IF statements. It should not change any functionality.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-11649
How was this patch tested?
Existing tests cover this.