Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run CI on PRs and fail on warnings #92

Merged
merged 2 commits into from
Dec 17, 2024
Merged

Conversation

Fokko
Copy link
Contributor

@Fokko Fokko commented Dec 4, 2024

The angolia search configuration was deprecated, so I took it from the docs: https://www.docsy.dev/docs/adding-content/search/#algolia-docsearch

tml:4:7": execute of template failed: template: 404.html:4:7: executing "404.html" at <partial "head.html" .>: error calling partial: execute of template failed: template: partials/head.html:66:3: executing "algolia/head" at <warnf `Config 'params.algolia_docsearch' is deprecated: use 'params.search.algolia'
      For details, see https://www.docsy.dev/docs/adding-content/search/#algolia-docsearch.`>: error calling warnf: Config 'params.algolia_docsearch' is deprecated: use 'params.search.algolia'
      For details, see https://www.docsy.dev/docs/adding-content/search/#algolia-docsearch.

@Fokko Fokko requested a review from wgtmac December 4, 2024 06:40
Fokko added a commit to Fokko/parquet-site that referenced this pull request Dec 4, 2024
I would recommend merging apache#92
first to make sure that the build passes.
Fokko added a commit to Fokko/parquet-site that referenced this pull request Dec 4, 2024
I would recommend merging apache#92
first to make sure that the build passes.
Copy link
Member

@wgtmac wgtmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vinooganesh
Copy link
Collaborator

vinooganesh commented Dec 4, 2024

Thanks @Fokko ! You may want to delete that config from here too:

@Fokko
Copy link
Contributor Author

Fokko commented Dec 4, 2024

@vinooganesh Got it, I wasn't sure if that was required. I copied it to hugo.toml to mimic the example docs. I've removed it from the html page.

Fokko added a commit that referenced this pull request Dec 17, 2024
I would recommend merging #92
first to make sure that the build passes.
@Fokko Fokko merged commit be49a89 into apache:production Dec 17, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants