Skip to content

Commit

Permalink
nits
Browse files Browse the repository at this point in the history
  • Loading branch information
adutra committed Nov 26, 2024
1 parent de64e59 commit c145788
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 8 deletions.
2 changes: 1 addition & 1 deletion polaris-service/src/main/resources/application.properties
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ quarkus.banner.path=polaris-banner.txt

quarkus.config.mapping.validate-unknown=true

quarkus.container-image.build=true
quarkus.container-image.build=false
quarkus.container-image.push=false
# quarkus.container-image.registry=ghcr.io
quarkus.container-image.group=apache
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -667,6 +667,7 @@ public void testRequestHeaderTooLarge() {
// In some runtime environments the request above will return a 431 but in others it'll result
// in a ProcessingException from the socket being closed. The test asserts that one of those
// things happens.
assertThat(e).hasMessageContaining("Connection was closed");
}
}

Expand All @@ -688,13 +689,9 @@ public void testRequestBodyTooLarge() {
assertThat(response)
.returns(Response.Status.REQUEST_ENTITY_TOO_LARGE.getStatusCode(), Response::getStatus);
} catch (ProcessingException e) {
// Quarkus will return a 413 response *and* close the connection;
// see io.quarkus.vertx.http.runtime.options.HttpServerCommonHandlers.
// In normal conditions, this will surface to the client as an exception due to the
// closed socket.
// But if the test is fast enough, the client may be able to fully process the response
// before the server closes the connection, in which case the client will see the
// 413 response.
// In some runtime environments the request above will return a 431 but in others it'll result
// in a ProcessingException from the socket being closed. The test asserts that one of those
// things happens.
assertThat(e).hasMessageContaining("Connection was closed");
}
}
Expand Down

0 comments on commit c145788

Please sign in to comment.