Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RANGER-5069: Add ability to Kafka authorizer to define super users through Kafka config #464

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+254 −87
Open

RANGER-5069: Add ability to Kafka authorizer to define super users through Kafka config #464

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions ...ommon/src/main/java/org/apache/ranger/authorization/hadoop/config/RangerPluginConfig.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@

import java.io.File;
import java.net.URL;
import java.util.Collection;
import java.util.Collections;
import java.util.HashSet;
import java.util.Set;
Expand Down Expand Up @@ -56,7 +57,7 @@ public class RangerPluginConfig extends RangerConfiguration {
private Set<String> auditExcludedUsers = Collections.emptySet();
private Set<String> auditExcludedGroups = Collections.emptySet();
private Set<String> auditExcludedRoles = Collections.emptySet();
private Set<String> superUsers = Collections.emptySet();
private Set<String> superUsers = new HashSet<>();
private Set<String> superGroups = Collections.emptySet();
private Set<String> serviceAdmins = Collections.emptySet();

Expand Down Expand Up @@ -224,7 +225,7 @@ public void setAuditExcludedUsersGroupsRoles(Set<String> users, Set<String> grou
}

public void setSuperUsersGroups(Set<String> users, Set<String> groups) {
superUsers = CollectionUtils.isEmpty(users) ? Collections.emptySet() : new HashSet<>(users);
superUsers = CollectionUtils.isEmpty(users) ? new HashSet<>() : new HashSet<>(users);
superGroups = CollectionUtils.isEmpty(groups) ? Collections.emptySet() : new HashSet<>(groups);

LOG.debug("superUsers={}, superGroups={}", superUsers, superGroups);
Expand Down Expand Up @@ -258,6 +259,12 @@ public boolean isServiceAdmin(String userName) {
return serviceAdmins.contains(userName);
}

public void addSuperUsers(Collection<String> users) {
if (users != null) {
superUsers.addAll(users);
}
}

private void addResourcesForServiceType(String serviceType) {
String auditCfg = "ranger-" + serviceType + "-audit.xml";
String securityCfg = "ranger-" + serviceType + "-security.xml";
Expand Down
44 changes: 44 additions & 0 deletions ...src/main/java/org/apache/ranger/authorization/kafka/authorizer/RangerKafkaAuthorizer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@
import java.util.Collection;
import java.util.Collections;
import java.util.Date;
import java.util.HashSet;
import java.util.List;
import java.util.Map;
import java.util.Set;
Expand All @@ -41,6 +42,7 @@
import org.apache.kafka.common.network.ListenerName;
import org.apache.kafka.common.resource.ResourceType;
import org.apache.kafka.common.security.JaasContext;
import org.apache.kafka.common.security.auth.KafkaPrincipal;
import org.apache.kafka.common.security.auth.SecurityProtocol;
import org.apache.kafka.common.utils.SecurityUtils;
import org.apache.kafka.server.authorizer.AclCreateResult;
Expand Down Expand Up @@ -80,6 +82,8 @@ public class RangerKafkaAuthorizer implements Authorizer {
public static final String ACCESS_TYPE_CLUSTER_ACTION = "cluster_action";
public static final String ACCESS_TYPE_IDEMPOTENT_WRITE = "idempotent_write";

private static final String KAFKA_SUPER_USERS_PROP = "super.users";

private static volatile RangerBasePlugin rangerPlugin = null;
RangerKafkaAuditHandler auditHandler = null;

Expand Down Expand Up @@ -218,13 +222,53 @@ public void configure(Map<String, ?> configs) {
rangerPlugin = new RangerBasePlugin("kafka", "kafka");
logger.info("Calling plugin.init()");
rangerPlugin.init();

Set<String> superUsersFromKafkaConfig = parseSuperUsersFromKafkaConfig(configs);
rangerPlugin.getPluginContext().getConfig().addSuperUsers(superUsersFromKafkaConfig);
logger.info("Super users added from Kafka config: " + superUsersFromKafkaConfig);

auditHandler = new RangerKafkaAuditHandler();
rangerPlugin.setResultProcessor(auditHandler);
}
}
}
}

private Set<String> parseSuperUsersFromKafkaConfig(Map<String, ?> configs) {
if (configs == null) {
return Collections.emptySet();
}

Object kafkaSuperUsersConfig = configs.get(KAFKA_SUPER_USERS_PROP);

if (kafkaSuperUsersConfig == null) {
return Collections.emptySet();
}
if (!(kafkaSuperUsersConfig instanceof String)) {
logger.warn("super.users in Kafka config could not be parsed");
return Collections.emptySet();
}

String kafkaSuperUsers = (String) kafkaSuperUsersConfig;
String[] principals = kafkaSuperUsers.split(";");

Set<String> superUserNames = new HashSet<>();
for (String principal : principals) {
try {
KafkaPrincipal parsedPrincipal = SecurityUtils.parseKafkaPrincipal(principal.trim());
String userName = parsedPrincipal.getName();
if (KafkaPrincipal.USER_TYPE.equals(parsedPrincipal.getPrincipalType()) && StringUtils.isNotEmpty(userName)) {
superUserNames.add(userName);
}
} catch (Exception e) {
logger.warn(String.format("Kafka principal: \"%s\" could not be parsed and will not be added " +
"to the authorized super users list", principal), e);
}
}

return Collections.unmodifiableSet(superUserNames);
}

@Override
public Map<Endpoint, ? extends CompletionStage<Void>> start(AuthorizerServerInfo serverInfo) {
return serverInfo.endpoints().stream()
Expand Down
Loading