-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ISSUE#173]Connect Exporter for Prometheus #200
Open
yhx-coder
wants to merge
6
commits into
apache:master
Choose a base branch
from
yhx-coder:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
ac86c1a
Clean up duplicate methods
yhx-coder f1d95bc
Merge branch 'master' into master
odbozhou 3cbb619
Merge branch 'apache:master' into master
yhx-coder ffa09d3
Merge branch 'apache:master' into master
yhx-coder cc28db3
Merge branch 'apache:master' into master
yhx-coder d6985d1
metrics exportor interface
yhx-coder File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,47 @@ | ||
<?xml version="1.0" encoding="UTF-8"?> | ||
<project xmlns="http://maven.apache.org/POM/4.0.0" | ||
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" | ||
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd"> | ||
<modelVersion>4.0.0</modelVersion> | ||
|
||
<groupId>org.apache.rocketmq</groupId> | ||
<artifactId>rocketmq-connect-metrics-exporter</artifactId> | ||
<version>1.0-SNAPSHOT</version> | ||
<name>rocketmq-connect-metrics-exporter</name> | ||
|
||
|
||
<properties> | ||
<maven.compiler.source>1.8</maven.compiler.source> | ||
<maven.compiler.target>1.8</maven.compiler.target> | ||
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding> | ||
<project.reporting.outputEncoding>UTF-8</project.reporting.outputEncoding> | ||
<openmessaging.connector.version>0.1.3</openmessaging.connector.version> | ||
</properties> | ||
|
||
<dependencies> | ||
<dependency> | ||
<groupId>io.openmessaging</groupId> | ||
<artifactId>openmessaging-connector</artifactId> | ||
<version>${openmessaging.connector.version}</version> | ||
</dependency> | ||
</dependencies> | ||
|
||
<build> | ||
<plugins> | ||
<plugin> | ||
<groupId>org.apache.maven.plugins</groupId> | ||
<artifactId>maven-compiler-plugin</artifactId> | ||
<version>3.6.1</version> | ||
<configuration> | ||
<source>${maven.compiler.source}</source> | ||
<target>${maven.compiler.target}</target> | ||
<compilerVersion>${maven.compiler.source}</compilerVersion> | ||
<showDeprecation>true</showDeprecation> | ||
<showWarnings>true</showWarnings> | ||
</configuration> | ||
</plugin> | ||
</plugins> | ||
</build> | ||
|
||
|
||
</project> |
41 changes: 41 additions & 0 deletions
41
...a/org/apache/rocket/connect/metrics/export/sink/connector/MetricsExportSinkConnector.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,41 @@ | ||
package org.apache.rocket.connect.metrics.export.sink.connector; | ||
|
||
import io.openmessaging.KeyValue; | ||
import io.openmessaging.connector.api.component.task.Task; | ||
import io.openmessaging.connector.api.component.task.sink.SinkConnector; | ||
import java.util.ArrayList; | ||
import java.util.List; | ||
import org.apache.rocket.connect.metrics.export.sink.util.ServiceProvicerUtil; | ||
|
||
public class MetricsExportSinkConnector extends SinkConnector { | ||
private KeyValue config; | ||
|
||
private List<MetricsExporter> metricsExporters; | ||
{ | ||
metricsExporters = ServiceProvicerUtil.getMetricsExporterServices(); | ||
} | ||
|
||
@Override public List<KeyValue> taskConfigs(int maxTasks) { | ||
List<KeyValue> configs = new ArrayList<>(); | ||
configs.add(config); | ||
return configs; | ||
} | ||
|
||
@Override public Class<? extends Task> taskClass() { | ||
return MetricsExportSinkTask.class; | ||
} | ||
|
||
@Override public void start(KeyValue config) { | ||
this.config = config; | ||
} | ||
|
||
@Override public void stop() { | ||
this.config = null; | ||
} | ||
|
||
@Override public void validate(KeyValue config) { | ||
for (MetricsExporter exporter: metricsExporters) { | ||
exporter.validate(config); | ||
} | ||
} | ||
} |
37 changes: 37 additions & 0 deletions
37
...n/java/org/apache/rocket/connect/metrics/export/sink/connector/MetricsExportSinkTask.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,37 @@ | ||
package org.apache.rocket.connect.metrics.export.sink.connector; | ||
|
||
import io.openmessaging.KeyValue; | ||
import io.openmessaging.connector.api.component.task.sink.SinkTask; | ||
import io.openmessaging.connector.api.component.task.sink.SinkTaskContext; | ||
import io.openmessaging.connector.api.data.ConnectRecord; | ||
import io.openmessaging.connector.api.errors.ConnectException; | ||
import java.util.List; | ||
import org.apache.rocket.connect.metrics.export.sink.util.ServiceProvicerUtil; | ||
|
||
|
||
public class MetricsExportSinkTask extends SinkTask { | ||
private List<MetricsExporter> metricsExporters; | ||
|
||
@Override public void put(List<ConnectRecord> sinkRecords) throws ConnectException { | ||
for (MetricsExporter exporter : metricsExporters) { | ||
exporter.export(sinkRecords); | ||
} | ||
} | ||
|
||
@Override public void start(KeyValue config) { | ||
for (MetricsExporter exporter : metricsExporters) { | ||
exporter.start(config); | ||
} | ||
} | ||
|
||
@Override public void stop() { | ||
for (MetricsExporter exporter : metricsExporters) { | ||
exporter.stop(); | ||
} | ||
} | ||
|
||
@Override public void init(SinkTaskContext sinkTaskContext) { | ||
super.init(sinkTaskContext); | ||
metricsExporters = ServiceProvicerUtil.getMetricsExporterServices(); | ||
} | ||
} |
16 changes: 16 additions & 0 deletions
16
...rc/main/java/org/apache/rocket/connect/metrics/export/sink/connector/MetricsExporter.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,16 @@ | ||
package org.apache.rocket.connect.metrics.export.sink.connector; | ||
|
||
import io.openmessaging.KeyValue; | ||
import io.openmessaging.connector.api.data.ConnectRecord; | ||
import java.util.List; | ||
|
||
public interface MetricsExporter { | ||
void export(List<ConnectRecord> sinkRecords); | ||
|
||
void validate(KeyValue config); | ||
|
||
void start(KeyValue config); | ||
|
||
void stop(); | ||
|
||
} |
23 changes: 23 additions & 0 deletions
23
...src/main/java/org/apache/rocket/connect/metrics/export/sink/util/ServiceProvicerUtil.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,23 @@ | ||
package org.apache.rocket.connect.metrics.export.sink.util; | ||
|
||
import java.util.ArrayList; | ||
import java.util.Iterator; | ||
import java.util.List; | ||
import java.util.ServiceLoader; | ||
import org.apache.rocket.connect.metrics.export.sink.connector.MetricsExporter; | ||
|
||
/** | ||
* @author: ming | ||
*/ | ||
public class ServiceProvicerUtil { | ||
|
||
public static List<MetricsExporter> getMetricsExporterServices(){ | ||
List<MetricsExporter> metricsExporterList = new ArrayList<>(); | ||
ServiceLoader<MetricsExporter> metricsExporters = ServiceLoader.load(MetricsExporter.class); | ||
Iterator<MetricsExporter> iterator = metricsExporters.iterator(); | ||
while (iterator.hasNext()){ | ||
metricsExporterList.add(iterator.next()); | ||
} | ||
return metricsExporterList; | ||
} | ||
} |
Empty file.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Has the implementation of MetricsExporter been submitted yet?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry not yet :( . But I am trying my best to finish a exporter for Prometheus which gets the metrics from the log files, and some preliminary knowledge is got. And I hear the sftp source connector (my upstream task) is designing in the last weekly meeting. So I'm waiting for the implementation
ConnectRecord
in it in order to complete my parsing.