Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #7296] Add ChannelEventListener for MQClientAPIImpl #7324

Merged
merged 3 commits into from
Oct 8, 2023

Conversation

drpmma
Copy link
Contributor

@drpmma drpmma commented Sep 7, 2023

  • add heartbeat when channel connect

Which Issue(s) This PR Fixes

Fixes #7323

Brief Description

Add ChannelEventListener for MQClientAPIImpl

How Did You Test This Change?

@codecov-commenter
Copy link

Codecov Report

Merging #7324 (2686759) into develop (e11e294) will increase coverage by 0.00%.
The diff coverage is 52.63%.

@@            Coverage Diff             @@
##             develop    #7324   +/-   ##
==========================================
  Coverage      42.69%   42.70%           
- Complexity      9474     9475    +1     
==========================================
  Files           1152     1152           
  Lines          82721    82737   +16     
  Branches       10781    10784    +3     
==========================================
+ Hits           35315    35330   +15     
- Misses         42997    43000    +3     
+ Partials        4409     4407    -2     
Files Changed Coverage Δ
...rocketmq/client/impl/factory/MQClientInstance.java 44.07% <35.71%> (-0.25%) ⬇️
...g/apache/rocketmq/client/impl/MQClientAPIImpl.java 23.22% <100.00%> (+0.10%) ⬆️
...e/rocketmq/remoting/netty/NettyRemotingClient.java 43.47% <100.00%> (+0.29%) ⬆️

... and 22 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@drpmma drpmma changed the title [ISSUE #7296] [TASK 2] Add ChannelEventListener for MQClientAPIImpl [ISSUE #7296] Add ChannelEventListener for MQClientAPIImpl Sep 7, 2023
Copy link
Contributor

@fuyou001 fuyou001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

fuyou001
fuyou001 previously approved these changes Sep 8, 2023
Copy link
Contributor

@fuyou001 fuyou001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@mxsm mxsm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

RongtongJin
RongtongJin previously approved these changes Sep 9, 2023
Copy link
Contributor

@joeCarf joeCarf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@drpmma drpmma dismissed stale reviews from RongtongJin and fuyou001 via b636ae3 October 8, 2023 03:52
@drpmma drpmma force-pushed the feature/add-channel-listener branch from b636ae3 to f1c382d Compare October 8, 2023 06:01
@drpmma drpmma merged commit b9ffe0f into apache:develop Oct 8, 2023
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement] [ISSUE #7296] [TASK 2] Add ChannelEventListener for MQClientAPIImpl
6 participants